Merge pull request routablehq#163 from EquityZen/master

ej2 · web-flow · commit e623957cbf21 · 2019-09-18T08:23:35.000-05:00
Update Invoice and SendMixin Classes
diff --git a/quickbooks/mixins.py b/quickbooks/mixins.py
@@ -1,3 +1,5 @@
+from future.moves.urllib.parse import quote
+
 import simplejson as json
 import six
 from .utils import build_where_clause, build_choose_clause
@@ -107,6 +109,7 @@ def send(self, qb=None, send_to=None):
         end_point = "{0}/{1}/send".format(self.qbo_object_name.lower(), self.Id)
 
         if send_to:
+            send_to = quote(send_to, safe='')
             end_point = "{0}?sendTo={1}".format(end_point, send_to)
 
         results = qb.misc_operation(end_point, None, 'application/octet-stream')
diff --git a/quickbooks/objects/invoice.py b/quickbooks/objects/invoice.py
@@ -58,6 +58,7 @@ def __init__(self):
         self.Deposit = 0
         self.Balance = 0
         self.AllowIPNPayment = True
+        self.AllowOnlineCreditCardPayment = False
         self.DocNumber = None
         self.PrivateNote = ""
         self.DueDate = ""
diff --git a/tests/unit/test_mixins.py b/tests/unit/test_mixins.py
@@ -1,5 +1,8 @@
+
 import os
+
 import unittest
+from future.moves.urllib.parse import quote
 
 from quickbooks.objects import Bill, Invoice
 
@@ -353,9 +356,12 @@ def test_send(self, mock_misc_op):
     def test_send_with_send_to_email(self, mock_misc_op):
         invoice = Invoice()
         invoice.Id = 2
-        invoice.send(qb=self.qb_client, send_to="test@email.com")
+        email = "test@email.com"
+        send_to_email = quote(email, safe='')
+
+        invoice.send(qb=self.qb_client, send_to=email)
 
-        mock_misc_op.assert_called_with("invoice/2/send?sendTo=test@email.com", None, 'application/octet-stream')
+        mock_misc_op.assert_called_with("invoice/2/send?sendTo={}".format(send_to_email), None, 'application/octet-stream')
 
 
 class VoidMixinTest(QuickbooksUnitTestCase):
