Skip to content

Commit 555cb7b

Browse files
committed
Update payment and paymentline fields.
1 parent 1e29297 commit 555cb7b

File tree

4 files changed

+20
-18
lines changed

4 files changed

+20
-18
lines changed

CHANGELOG.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Changelog
22
========
33

4+
* 0.3.11 (February 24, 2016)
5+
* Updated field defaults on Payment object.
6+
* Added minor version 4 field to Payment object.
7+
* Removed invalid fields from PaymentLine object.
8+
49
* 0.3.10 (February 19, 2016)
510
* Updated field defaults on Item object
611

quickbooks/objects/payment.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,11 @@ class PaymentLine(QuickbooksBaseObject):
1111

1212
def __init__(self):
1313
super(PaymentLine, self).__init__()
14-
self.Id = 0
15-
self.LineNum = 0
16-
self.Description = ""
1714
self.Amount = 0
18-
1915
self.LinkedTxn = []
2016

2117
def __str__(self):
22-
return "[{0}] {1} {2}".format(self.LineNum, self.Description, self.Amount)
18+
return str(self.Amount)
2319

2420

2521
@python_2_unicode_compatible
@@ -58,22 +54,25 @@ class Payment(QuickbooksManagedObject, QuickbooksTransactionEntity):
5854

5955
def __init__(self):
6056
super(Payment, self).__init__()
61-
self.PaymentRefNum = ""
62-
self.TotalAmt = 0
63-
self.UnappliedAmt = 0
64-
self.ExchangeRate = 1
65-
self.TxnDate = ""
66-
self.TxnSource = ""
67-
self.PrivateNote = ""
68-
self.TxnStatus = "PAID"
57+
self.PaymentRefNum = None
58+
self.TotalAmt = None
59+
self.UnappliedAmt = None # Readonly
60+
self.ExchangeRate = None
61+
self.TxnDate = None
62+
self.TxnSource = None
63+
self.PrivateNote = None
64+
self.TxnStatus = None
6965

7066
self.CreditCardPayment = None
7167
self.ARAccountRef = None
7268
self.CustomerRef = None
73-
self.CurrencyRef = None
69+
self.CurrencyRef = None # Readonly
7470
self.PaymentMethodRef = None
7571
self.DepositToAccountRef = None
7672
self.Line = []
7773

74+
# These fields are for minor version 4
75+
self.TransactionLocationType = None
76+
7877
def __str__(self):
7978
return str(self.TotalAmt)

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def read(*parts):
1010
return fp.read()
1111

1212

13-
VERSION = (0, 3, 10)
13+
VERSION = (0, 3, 11)
1414
version = '.'.join(map(str, VERSION))
1515

1616
setup(

tests/unit/objects/test_payment.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@
66
class PaymentLineTests(unittest.TestCase):
77
def test_unicode(self):
88
payment_line = PaymentLine()
9-
payment_line.LineNum = 1
10-
payment_line.Description = "Product Description"
119
payment_line.Amount = 100
1210

13-
self.assertEquals(str(payment_line), "[1] Product Description 100")
11+
self.assertEquals(str(payment_line), "100")
1412

1513

1614
class PaymentTests(unittest.TestCase):

0 commit comments

Comments
 (0)