Skip to content

Commit e7a0350

Browse files
committed
Safer to load before clearing loader.
Performing the import twice has no ill effect. However, if a second thread were to come in between the clear of the loader and its invocation, there would be no metadata and no loader for it either.
1 parent 9cc2949 commit e7a0350

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

python/phonenumbers/phonemetadata.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,17 +229,17 @@ def metadata_for_region(kls, region_code, default=None):
229229
loader = kls._region_available.get(region_code, None)
230230
if loader is not None:
231231
# Region metadata is available but has not yet been loaded. Do so now.
232-
kls._region_available[region_code] = None
233232
loader()
233+
kls._region_available[region_code] = None
234234
return kls._region_metadata.get(region_code, default)
235235

236236
@classmethod
237237
def metadata_for_nongeo_region(kls, country_code, default=None):
238238
loader = kls._country_code_available.get(country_code, None)
239239
if loader is not None:
240240
# Region metadata is available but has not yet been loaded. Do so now.
241-
kls._country_code_available[country_code] = None
242241
loader()
242+
kls._country_code_available[country_code] = None
243243
return kls._country_code_metadata.get(country_code, default)
244244

245245
@classmethod

0 commit comments

Comments
 (0)