Skip to content

Commit cced349

Browse files
daviddrysdaledaviddrysdale
committed
Use __init__.__version__ to hold master version number for package.
1 parent 2a81fc4 commit cced349

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

‎python/makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ coverage_generate:
2323
coverage_report:
2424
coverage -m -r $(COVERAGE_FILES)
2525

26-
VERSION=3.4a1
26+
VERSION=$(shell grep __version__ phonenumbers/__init__.py | sed 's/__version__ = "\(.*\)"/\1/')
2727
TARBALL=dist/phonenumbers-$(VERSION).tar.gz
2828
# Build setuptools packaged tarball $(TARBALL)
2929
sdist:

‎python/phonenumbers/__init__.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@
7272
# I'll use regular expressions." Now they have two problems.'
7373
# -- jwz 1997-08-12
7474

75+
# Version number is taken from the upstream libphonenumber version
76+
__version__ = "3.4a1"
77+
7578
# Data class definitions
7679
from phonenumber import PhoneNumber, CountryCodeSource
7780
from phonemetadata import NumberFormat, PhoneNumberDesc, PhoneMetadata

‎python/setup.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,11 @@
2929
if not python_24:
3030
raise RuntimeError("Python 2.4 or newer is required")
3131

32+
# Discover version from local code
33+
from phonenumbers import __version__
34+
3235
distutils.core.setup(name='phonenumbers',
33-
version='3.4a1',
36+
version=__version__,
3437
description="Python version of Google's common library for parsing, formatting, storing and validating international phone numbers.",
3538
author='David Drysdale',
3639
author_email='dmd@lurklurk.org',

0 commit comments

Comments
 (0)