Skip to content

Commit b14b4f1

Browse files
committed
Rename _number_desc_by_type()
To better match the Java getNumberDescByType()
1 parent f249ce1 commit b14b4f1

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

python/phonenumbers/phonenumberutil.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1646,7 +1646,7 @@ def invalid_example_number(region_code):
16461646
# number lengths and we may have to make it very short before we get an
16471647
# invalid number.
16481648
metadata = PhoneMetadata.metadata_for_region(region_code.upper())
1649-
desc = _number_desc_for_type(metadata, PhoneNumberType.FIXED_LINE)
1649+
desc = _number_desc_by_type(metadata, PhoneNumberType.FIXED_LINE)
16501650
if desc.example_number is None:
16511651
# This shouldn't happen; we have a test for this.
16521652
return None # pragma no cover
@@ -1706,7 +1706,7 @@ def example_number_for_type(region_code, num_type):
17061706
if not _is_valid_region_code(region_code):
17071707
return None
17081708
metadata = PhoneMetadata.metadata_for_region(region_code.upper())
1709-
desc = _number_desc_for_type(metadata, num_type)
1709+
desc = _number_desc_by_type(metadata, num_type)
17101710
if desc.example_number is not None:
17111711
try:
17121712
return parse(desc.example_number, region_code)
@@ -1732,7 +1732,7 @@ def _example_number_anywhere_for_type(num_type):
17321732
# If there wasn't an example number for a region, try the non-geographical entities.
17331733
for country_calling_code in COUNTRY_CODES_FOR_NON_GEO_REGIONS:
17341734
metadata = PhoneMetadata.metadata_for_nongeo_region(country_calling_code, None)
1735-
desc = _number_desc_for_type(metadata, num_type)
1735+
desc = _number_desc_by_type(metadata, num_type)
17361736
if desc.example_number is not None:
17371737
try:
17381738
return parse(_PLUS_SIGN + unicod(country_calling_code) + desc.example_number, UNKNOWN_REGION)
@@ -1784,7 +1784,7 @@ def _maybe_append_formatted_extension(numobj, metadata, num_format, number):
17841784
return number
17851785

17861786

1787-
def _number_desc_for_type(metadata, num_type):
1787+
def _number_desc_by_type(metadata, num_type):
17881788
"""Return the PhoneNumberDesc of the metadata for the given number type"""
17891789
if num_type == PhoneNumberType.PREMIUM_RATE:
17901790
return metadata.premium_rate

0 commit comments

Comments
 (0)