Skip to content

Commit 8f535a7

Browse files
committed
Restore protobuf conversion utilities
Broken since 37ef497 ("Merge upstream code changes"). Rebuilt with `make pb2` from tools/python
1 parent 2d5d8a0 commit 8f535a7

3 files changed

Lines changed: 41 additions & 23 deletions

File tree

python/phonenumbers/pb2/__init__.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@
1010
>>> y_pb = phonenumber_pb2.PhoneNumber()
1111
>>> y_pb.country_code = 44
1212
>>> y_pb.national_number = 7912345678
13+
>>> y_pb.country_code_source = phonenumber_pb2.PhoneNumber.UNSPECIFIED
1314
>>> print str(y_pb).strip()
1415
country_code: 44
1516
national_number: 7912345678
17+
country_code_source: UNSPECIFIED
1618
>>> # Check italian_leading_zero default value when not set
1719
>>> y_pb.italian_leading_zero
1820
False
@@ -23,6 +25,7 @@
2325
>>> print str(x_pb).strip()
2426
country_code: 44
2527
national_number: 7912345678
28+
country_code_source: UNSPECIFIED
2629
>>> x_py == y_py
2730
True
2831
>>> x_pb == y_pb
@@ -33,8 +36,8 @@
3336
False
3437
"""
3538

36-
from phonenumber_pb2 import PhoneNumber as PhoneNumberPB
37-
from phonenumbers import PhoneNumber
39+
from .phonenumber_pb2 import PhoneNumber as PhoneNumberPB
40+
from phonenumbers import PhoneNumber, CountryCodeSource
3841

3942
def PBToPy(numpb):
4043
"""Convert phonenumber_pb2.PhoneNumber to phonenumber.PhoneNumber"""
@@ -44,7 +47,7 @@ def PBToPy(numpb):
4447
italian_leading_zero=numpb.italian_leading_zero if numpb.HasField("italian_leading_zero") else None,
4548
number_of_leading_zeros=numpb.number_of_leading_zeros if numpb.HasField("number_of_leading_zeros") else None,
4649
raw_input=numpb.raw_input if numpb.HasField("raw_input") else None,
47-
country_code_source=numpb.country_code_source if numpb.HasField("country_code_source") else None,
50+
country_code_source=numpb.country_code_source if numpb.HasField("country_code_source") else CountryCodeSource.UNSPECIFIED,
4851
preferred_domestic_carrier_code=numpb.preferred_domestic_carrier_code if numpb.HasField("preferred_domestic_carrier_code") else None)
4952

5053
def PyToPB(numobj):
@@ -62,8 +65,7 @@ def PyToPB(numobj):
6265
numpb.number_of_leading_zeros = numobj.number_of_leading_zeros
6366
if numobj.raw_input is not None:
6467
numpb.raw_input = numobj.raw_input
65-
if numobj.country_code_source is not None:
66-
numpb.country_code_source = numobj.country_code_source
68+
numpb.country_code_source = numobj.country_code_source
6769
if numobj.preferred_domestic_carrier_code is not None:
6870
numpb.preferred_domestic_carrier_code = numobj.preferred_domestic_carrier_code
6971
return numpb

python/phonenumbers/pb2/phonenumber_pb2.py

Lines changed: 33 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/tests/pb2/converttest.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ def testMissingFields(self):
5454
preferred_domestic_carrier_code="123")
5555
fieldnames = ('country_code', 'national_number', 'extension',
5656
'italian_leading_zero', 'number_of_leading_zeros',
57-
'raw_input', 'country_code_source',
58-
'preferred_domestic_carrier_code')
57+
'raw_input', 'preferred_domestic_carrier_code')
5958
for field in fieldnames:
6059
numobj = PhoneNumber()
6160
numobj.merge_from(fullobj)

0 commit comments

Comments
 (0)