Skip to content

Commit 8bfcc87

Browse files
lieryandaviddrysdale
authored andcommitted
Use class name for repr() instead of hard-coded string (daviddrysdale#140)
This makes it easier to distinguish the repr of inherited classes (e.g. FrozenPhoneNumber)
1 parent b697f7b commit 8bfcc87

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

python/phonenumbers/phonenumber.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,11 @@ def __ne__(self, other):
211211
return not self.__eq__(other)
212212

213213
def __repr__(self):
214-
return (unicod("PhoneNumber(country_code=%s, national_number=%s, extension=%s, " +
214+
return (unicod("%s(country_code=%s, national_number=%s, extension=%s, " +
215215
"italian_leading_zero=%s, number_of_leading_zeros=%s, " +
216216
"country_code_source=%s, preferred_domestic_carrier_code=%s)") %
217-
(self.country_code,
217+
(type(self).__name__,
218+
self.country_code,
218219
self.national_number,
219220
rpr(self.extension),
220221
self.italian_leading_zero,
@@ -258,3 +259,4 @@ def __init__(self, *args, **kwargs):
258259
super(FrozenPhoneNumber, self).__init__(**args[0].__dict__)
259260
else:
260261
super(FrozenPhoneNumber, self).__init__(*args, **kwargs)
262+

python/tests/phonenumberutiltest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2956,6 +2956,7 @@ def testFrozenPhoneNumberImmutable(self):
29562956
self.fail("Expected exception on __delattr__")
29572957
except TypeError:
29582958
pass
2959+
self.assertEqual(repr(frozen1), "FrozenPhoneNumber(country_code=39, national_number=236618300, extension=None, italian_leading_zero=True, number_of_leading_zeros=None, country_code_source=0, preferred_domestic_carrier_code=None)")
29592960

29602961
def testMetadataImmutable(self):
29612962
desc = PhoneNumberDesc(national_number_pattern="\\d{4,8}")

0 commit comments

Comments
 (0)