Skip to content

Commit 7be5de2

Browse files
committed
buildmetadata: drop unused fill_na param
1 parent ea74992 commit 7be5de2

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tools/python/buildmetadatafromxml.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def __unicode__(self):
311311

312312
class XPhoneNumberDesc(UnicodeMixin):
313313
"""Parse PhoneNumberDesc object from XML element"""
314-
def __init__(self, xterritory, tag, template=None, fill_na=True, general_desc=False):
314+
def __init__(self, xterritory, tag, template=None, general_desc=False):
315315
id = xterritory.attrib['id']
316316
xtag = _get_unique_child(xterritory, tag)
317317
self.xtag = xtag
@@ -439,16 +439,16 @@ def __init__(self, xterritory, short_data):
439439
# However the general_desc is first and special; it has form:
440440
# (nationalNumberPattern, possibleNumberPattern)
441441
# and it will be used to fill out missing fields in many of the other PhoneNumberDesc elements.
442-
self.o.general_desc = XPhoneNumberDesc(xterritory, 'generalDesc', fill_na=False, general_desc=True)
442+
self.o.general_desc = XPhoneNumberDesc(xterritory, 'generalDesc', general_desc=True)
443443

444444
# areaCodeOptional is in the XML but not used in the code.
445445
self.o.area_code_optional = XPhoneNumberDesc(xterritory, 'areaCodeOptional', template=self.o.general_desc.o)
446446
self.o.toll_free = XPhoneNumberDesc(xterritory, 'tollFree', template=self.o.general_desc.o)
447447
self.o.premium_rate = XPhoneNumberDesc(xterritory, 'premiumRate', template=self.o.general_desc.o)
448448
if not short_data:
449449
# Mobile and fixed-line descriptions do not inherit anything from the general_desc
450-
self.o.fixed_line = XPhoneNumberDesc(xterritory, 'fixedLine', fill_na=False)
451-
self.o.mobile = XPhoneNumberDesc(xterritory, 'mobile', fill_na=False)
450+
self.o.fixed_line = XPhoneNumberDesc(xterritory, 'fixedLine')
451+
self.o.mobile = XPhoneNumberDesc(xterritory, 'mobile')
452452

453453
self.o.pager = XPhoneNumberDesc(xterritory, 'pager', template=self.o.general_desc.o)
454454
self.o.shared_cost = XPhoneNumberDesc(xterritory, 'sharedCost', template=self.o.general_desc.o)

0 commit comments

Comments
 (0)