Skip to content

Commit 369bc47

Browse files
daviddrysdaledaviddrysdale
committed
Add unit tests to restore 100% coverage
1 parent 1bd9b60 commit 369bc47

3 files changed

Lines changed: 28 additions & 12 deletions

File tree

‎python/tests/asyoutypetest.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -892,6 +892,7 @@ def testEdgeCases(self):
892892
del phonenumberutil.COUNTRY_CODE_TO_REGION_CODE[384]
893893
phonenumberutil.SUPPORTED_REGIONS.remove('XX')
894894
del PhoneMetadata.region_metadata['XX']
895-
# Hit internal error arm
895+
# Hit internal error arms
896+
self.assertEqual("1234", formatter._input_accrued_national_number())
896897
formatter._national_number = ""
897898
self.assertEqual("", formatter._input_accrued_national_number())

‎python/tests/examplenumberstest.py‎

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -144,20 +144,30 @@ def testBlankMetadata(self):
144144

145145
def testFormatNumberForMobile(self):
146146
# Python version extra test. Special cases for CO and BR in
147-
# format_number_for_mobile_dialing()
147+
# format_number_for_mobile_dialing(), included here so that real metadata is used
148148
coNumberFixed = PhoneNumber(country_code=57, national_number=12345678L)
149+
coNumberMobile = PhoneNumber(country_code=57, national_number=3211234567L)
150+
peNumberFixed = PhoneNumber(country_code=51, national_number=11234567L)
149151
brNumberFixed = PhoneNumber(country_code=55, national_number=1123456789L)
150152
brNumberMobile = PhoneNumber(country_code=55, national_number=1161234567L,
151153
preferred_domestic_carrier_code="303")
152154
self.assertEqual("0312345678",
153-
phonenumberutil.format_number_for_mobile_dialing(coNumberFixed, "CO", False))
155+
phonenumberutil.format_number_for_mobile_dialing(coNumberFixed, "CO", False))
154156
self.assertEqual("03 1 2345678",
155-
phonenumberutil.format_number_for_mobile_dialing(coNumberFixed, "CO", True))
157+
phonenumberutil.format_number_for_mobile_dialing(coNumberFixed, "CO", True))
158+
self.assertEqual("3211234567",
159+
phonenumberutil.format_number_for_mobile_dialing(coNumberMobile, "CO", False))
160+
self.assertEqual("321 1234567",
161+
phonenumberutil.format_number_for_mobile_dialing(coNumberMobile, "CO", True))
162+
self.assertEqual("011234567",
163+
phonenumberutil.format_number_for_mobile_dialing(peNumberFixed, "PE", False))
164+
self.assertEqual("(01) 1234567",
165+
phonenumberutil.format_number_for_mobile_dialing(peNumberFixed, "PE", True))
156166
self.assertEqual("",
157-
phonenumberutil.format_number_for_mobile_dialing(brNumberFixed, "BR", False))
167+
phonenumberutil.format_number_for_mobile_dialing(brNumberFixed, "BR", False))
158168
self.assertEqual("",
159-
phonenumberutil.format_number_for_mobile_dialing(brNumberFixed, "BR", True))
169+
phonenumberutil.format_number_for_mobile_dialing(brNumberFixed, "BR", True))
160170
self.assertEqual("03031161234567",
161-
phonenumberutil.format_number_for_mobile_dialing(brNumberMobile, "BR", False))
171+
phonenumberutil.format_number_for_mobile_dialing(brNumberMobile, "BR", False))
162172
self.assertEqual("0 303 (11) 6123-4567",
163-
phonenumberutil.format_number_for_mobile_dialing(brNumberMobile, "BR", True))
173+
phonenumberutil.format_number_for_mobile_dialing(brNumberMobile, "BR", True))

‎python/tests/geocodertest.py‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,13 +158,18 @@ def testCoverage(self):
158158
# Add in some script and region specific fictional names
159159
TEST_GEOCODE_DATA['1650960'] = {'en': u'Mountain View, CA',
160160
"en_GB": u'Mountain View California',
161+
"en_US": u'Mountain View, Sunny California',
161162
"en_Latn": u'MountainView'}
162163
# The following test might one day return "Mountain View California"
163164
self.assertEqual("United States",
164-
geocoder.description_for_number(US_NUMBER2, _ENGLISH, region="GB"))
165+
geocoder.description_for_number(US_NUMBER2, _ENGLISH, region="GB"))
166+
self.assertEqual("Mountain View, Sunny California",
167+
geocoder.description_for_number(US_NUMBER2, _ENGLISH, region="US"))
165168
self.assertEqual("MountainView",
166-
geocoder.description_for_number(US_NUMBER2, _ENGLISH, script="Latn"))
167-
# The following test might one day return "MountainView"
169+
geocoder.description_for_number(US_NUMBER2, _ENGLISH, script="Latn"))
168170
self.assertEqual("United States",
169-
geocoder.description_for_number(US_NUMBER2, _ENGLISH, script="Latn", region="GB"))
171+
geocoder.description_for_number(US_NUMBER2, _ENGLISH, script="Latn", region="GB"))
172+
# Get a different result when there is a script-specific variant
173+
self.assertEqual("MountainView",
174+
geocoder.description_for_number(US_NUMBER2, _ENGLISH, script="Latn", region="US"))
170175
TEST_GEOCODE_DATA['1650960'] = {'en': u'Mountain View, CA'}

0 commit comments

Comments
 (0)