Skip to content

Commit 052cb44

Browse files
daviddrysdaledaviddrysdale
committed
Note divergence from upstream Java behaviour
Currently expecting that the possible_length information will be self-contained for each number description; this differs from the upstream Java behaviour, where empty values inherit from the general description.
1 parent 9add688 commit 052cb44

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎python/tests/phonenumberutiltest.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ def testGetInstanceLoadUSMetadata(self):
111111
self.assertTrue(metadata.general_desc == metadata.fixed_line)
112112
self.assertEqual("\\d{10}", metadata.toll_free.possible_number_pattern)
113113
self.assertEqual(10, metadata.general_desc.possible_length[0])
114+
# Python version: each number type description has its own possible_length value,
115+
# rather than inheriting from the general_desc (like the Java code does).
114116
self.assertEqual(1, len(metadata.toll_free.possible_length))
115117
self.assertEqual(10, metadata.toll_free.possible_length[0])
116118
self.assertEqual("900\\d{7}", metadata.premium_rate.national_number_pattern)
@@ -132,6 +134,8 @@ def testGetInstanceLoadDEMetadata(self):
132134
self.assertEqual("\\1 \\2 \\3", metadata.number_format[5].format)
133135
self.assertEqual(2, len(metadata.general_desc.possible_length_local_only))
134136
self.assertEqual(8, len(metadata.general_desc.possible_length))
137+
# Python version: each number type description has its own possible_length value,
138+
# rather than inheriting from the general_desc (like the Java code does).
135139
self.assertEqual(8, len(metadata.fixed_line.possible_length))
136140
self.assertEqual(2, len(metadata.mobile.possible_length))
137141
self.assertEqual("(?:[24-6]\\d{2}|3[03-9]\\d|[789](?:0[2-9]|[1-9]\\d))\\d{1,8}",

0 commit comments

Comments
 (0)