add len(diff) instead of diff.size

Huang Huang · Huang Huang · commit c0b1ab9024ba · 2013-11-01T14:32:49.000+08:00
diff --git a/src/diff.c b/src/diff.c
@@ -249,11 +249,11 @@ PyTypeObject DiffIterType = {
     (iternextfunc) DiffIter_iternext,          /* tp_iternext       */
 };
 
-PyDoc_STRVAR(Diff_size__doc__, "Returns the number of deltas/patches in this diff.");
-PyObject *
-Diff_size__get__(Diff *self)
+Py_ssize_t
+Diff_len(Diff *self)
 {
-    return PyLong_FromSize_t(git_diff_num_deltas(self->list));
+    assert(self->list);
+    return (Py_ssize_t)git_diff_num_deltas(self->list);
 }
 
 PyDoc_STRVAR(Diff_patch__doc__, "Patch diff string.");
@@ -446,12 +446,11 @@ Diff_dealloc(Diff *self)
 
 PyGetSetDef Diff_getseters[] = {
     GETTER(Diff, patch),
-    GETTER(Diff, size),
     {NULL}
 };
 
 PyMappingMethods Diff_as_mapping = {
-    0,                               /* mp_length */
+    (lenfunc)Diff_len,               /* mp_length */
     (binaryfunc)Diff_getitem,        /* mp_subscript */
     0,                               /* mp_ass_subscript */
 };
diff --git a/test/test_diff.py b/test/test_diff.py
@@ -254,7 +254,7 @@ def test_diff_patch(self):
 
         diff = commit_a.tree.diff_to_tree(commit_b.tree)
         self.assertEqual(diff.patch, PATCH)
-        self.assertEqual(diff.size, len([patch for patch in diff]))
+        self.assertEqual(len(diff), len([patch for patch in diff]))
 
     def test_diff_oids(self):
         commit_a = self.repo[COMMIT_SHA1_1]
