Review tweaks

rcoup · rcoup · commit 8bcb129b8b69 · 2019-06-14T15:56:45.000+01:00
diff --git a/src/tree.c b/src/tree.c
@@ -51,9 +51,7 @@ void
 TreeEntry_dealloc(TreeEntry *self)
 {
     git_tree_entry_free((git_tree_entry*)self->entry);
-    if (self->repo) {
-        Py_CLEAR(self->repo);
-    }
+    Py_CLEAR(self->repo);
     PyObject_Del(self);
 }
 
@@ -506,11 +504,8 @@ wrap_tree_entry(const git_tree_entry *entry, Repository *repo)
     if (py_entry)
     {
         py_entry->entry = entry;
-        if (repo)
-        {
-            py_entry->repo = repo;
-            Py_INCREF(repo);
-        }
+        py_entry->repo = repo;  // can be NULL
+        Py_XINCREF(repo);
    }
 
     return py_entry;

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,7 @@ void`
`51`	`51`	`TreeEntry_dealloc(TreeEntry *self)`
`52`	`52`	`{`
`53`	`53`	`git_tree_entry_free((git_tree_entry*)self->entry);`
`54`		`- if (self->repo) {`
`55`		`- Py_CLEAR(self->repo);`
`56`		`- }`
	`54`	`+ Py_CLEAR(self->repo);`
`57`	`55`	`PyObject_Del(self);`
`58`	`56`	`}`
`59`	`57`
`@@ -506,11 +504,8 @@ wrap_tree_entry(const git_tree_entry entry, Repository repo)`
`506`	`504`	`if (py_entry)`
`507`	`505`	`{`
`508`	`506`	`py_entry->entry = entry;`
`509`		`- if (repo)`
`510`		`- {`
`511`		`- py_entry->repo = repo;`
`512`		`- Py_INCREF(repo);`
`513`		`- }`
	`507`	`+ py_entry->repo = repo; // can be NULL`
	`508`	`+ Py_XINCREF(repo);`
`514`	`509`	`}`
`515`	`510`
`516`	`511`	`return py_entry;`