Skip to content

Commit d94f89a

Browse files
committed
update metaflow R install function. remove cran check from github action
1 parent b73e697 commit d94f89a

4 files changed

Lines changed: 3 additions & 28 deletions

File tree

.github/workflows/publish.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,6 @@ jobs:
5555
R CMD INSTALL R
5656
Rscript -e 'install.packages(c("data.table", "caret", "glmnet", "Matrix", "rjson"), repos="https://cloud.r-project.org", Ncpus=8)'
5757
58-
- name: Install latex for CRAN compatibility checks
59-
if: matrix.lang == 'R' && matrix.os == 'ubuntu-latest'
60-
uses: r-lib/actions/setup-tinytex@v1
61-
62-
- name: Check CRAN compatibility
63-
if: matrix.lang == 'R' && matrix.os == 'ubuntu-latest'
64-
run: |
65-
cd R/
66-
bash ./check_as_cran.sh
67-
6858
- name: Execute R tests
6959
if: matrix.lang == 'R'
7060
run: |

.github/workflows/test.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,6 @@ jobs:
5959
R CMD INSTALL R
6060
Rscript -e 'install.packages(c("data.table", "caret", "glmnet", "Matrix", "rjson"), repos="https://cloud.r-project.org", Ncpus=8)'
6161
62-
- name: Install latex for CRAN compatibility checks
63-
if: matrix.lang == 'R' && matrix.os == 'ubuntu-latest'
64-
uses: r-lib/actions/setup-tinytex@v1
65-
66-
- name: Check CRAN compatibility
67-
if: matrix.lang == 'R' && matrix.os == 'ubuntu-latest'
68-
run: |
69-
cd R/
70-
bash ./check_as_cran.sh
71-
7262
- name: Execute R tests
7363
if: matrix.lang == 'R'
7464
run: |

R/R/utils.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,11 +266,11 @@ test <- function() {
266266
}
267267

268268
#' Install Metaflow python dependencies
269-
#' @param user_install Whether or not to install into the user directory for pip install. Default to TRUE.
269+
#' @param user Whether or not to install into the user directory for pip install. Default to TRUE.
270270
#' @param upgrade Whether or not to upgrade metaflow python package. Default to FALSE.
271271
#' @export
272-
install <- function(user_install=TRUE, upgrade=FALSE) {
273-
if (user_install){
272+
install <- function(user=TRUE, upgrade=FALSE) {
273+
if (user){
274274
user_flag = "--user"
275275
} else {
276276
user_flag = ""

R/tests/test_tutorials.sh

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)