Fix Netflix#305: Default 'help' for parameters was not handled properly (Netflix#318)

romain-intel · web-flow · commit 128622ab889d · 2020-09-03T10:50:35.000-07:00
diff --git a/metaflow/parameters.py b/metaflow/parameters.py
@@ -185,7 +185,9 @@ def option_kwargs(self, deploy_mode):
         kwargs = self.kwargs
         if isinstance(kwargs.get('default'), DeployTimeField) and not deploy_mode:
             ret = dict(kwargs)
-            ret['help'] = kwargs.get('help', '') + \
+            help_msg = kwargs.get('help')
+            help_msg = '' if help_msg is None else help_msg
+            ret['help'] = help_msg + \
                 "[default: deploy-time value of '%s']" % self.name
             ret['default'] = None
             ret['required'] = False
@@ -248,4 +250,4 @@ def set_parameters(flow, kwargs):
         parameter_list_length += len((param.name + str(val)).encode("utf-8"))
         num_parameters += 1
         val = val.split(param.separator) if val and param.separator else val
-        setattr(flow, var, val)
+        setattr(flow, var, val)
