Skip to content

Commit 0f0cee4

Browse files
committed
trezor and clones: sign tx version too
1 parent 2729909 commit 0f0cee4

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

electrum/plugins/keepkey/keepkey.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,8 @@ def sign_transaction(self, keystore, tx, prev_tx, xpub_path):
289289
client = self.get_client(keystore)
290290
inputs = self.tx_inputs(tx, True)
291291
outputs = self.tx_outputs(keystore.get_derivation(), tx)
292-
signatures = client.sign_tx(self.get_coin_name(), inputs, outputs, lock_time=tx.locktime)[0]
292+
signatures = client.sign_tx(self.get_coin_name(), inputs, outputs,
293+
lock_time=tx.locktime, version=tx.version)[0]
293294
signatures = [(bh2u(x) + '01') for x in signatures]
294295
tx.update_signatures(signatures)
295296

electrum/plugins/safe_t/safe_t.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,8 @@ def sign_transaction(self, keystore, tx, prev_tx, xpub_path):
306306
client = self.get_client(keystore)
307307
inputs = self.tx_inputs(tx, True)
308308
outputs = self.tx_outputs(keystore.get_derivation(), tx)
309-
signatures = client.sign_tx(self.get_coin_name(), inputs, outputs, lock_time=tx.locktime)[0]
309+
signatures = client.sign_tx(self.get_coin_name(), inputs, outputs,
310+
lock_time=tx.locktime, version=tx.version)[0]
310311
signatures = [(bh2u(x) + '01') for x in signatures]
311312
tx.update_signatures(signatures)
312313

electrum/plugins/trezor/trezor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ def sign_transaction(self, keystore, tx, prev_tx, xpub_path):
310310
client = self.get_client(keystore)
311311
inputs = self.tx_inputs(tx, xpub_path, True)
312312
outputs = self.tx_outputs(keystore.get_derivation(), tx)
313-
details = SignTx(lock_time=tx.locktime)
313+
details = SignTx(lock_time=tx.locktime, version=tx.version)
314314
signatures, _ = client.sign_tx(self.get_coin_name(), inputs, outputs, details=details, prev_txes=prev_tx)
315315
signatures = [(bh2u(x) + '01') for x in signatures]
316316
tx.update_signatures(signatures)

0 commit comments

Comments
 (0)