Return 200 OK instead of 404 for lazy function invocation (just for clarity)

seratch · seratch · commit 7b9f55553d91 · 2020-09-13T15:09:10.000+09:00
diff --git a/slack_bolt/app/app.py b/slack_bolt/app/app.py
@@ -282,7 +282,8 @@ def run_listener(
                         self.lazy_listener_runner.run(
                             function=lazy_func, request=request
                         )
-                        return None
+                        # This HTTP response won't be sent to Slack API servers.
+                        return BoltResponse(status=200)
                     else:
                         continue
                 else:
@@ -328,7 +329,8 @@ def run_ack_function_asynchronously():
                         self.lazy_listener_runner.run(
                             function=lazy_func, request=request
                         )
-                        return None
+                        # This HTTP response won't be sent to Slack API servers.
+                        return BoltResponse(status=200)
                     else:
                         continue
                 else:
diff --git a/slack_bolt/app/async_app.py b/slack_bolt/app/async_app.py
@@ -300,9 +300,11 @@ async def run_async_listener(
                 if request.lazy_function_name:
                     func_name = lazy_func.__name__
                     if func_name == request.lazy_function_name:
-                        return await self.lazy_listener_runner.run(
+                        await self.lazy_listener_runner.run(
                             function=lazy_func, request=request
                         )
+                        # This HTTP response won't be sent to Slack API servers.
+                        return BoltResponse(status=200)
                     else:
                         continue
                 else:
@@ -354,9 +356,11 @@ async def run_ack_function_asynchronously(
                 if request.lazy_function_name:
                     func_name = lazy_func.__name__
                     if func_name == request.lazy_function_name:
-                        return await self.lazy_listener_runner.run(
+                        await self.lazy_listener_runner.run(
                             function=lazy_func, request=request
                         )
+                        # This HTTP response won't be sent to Slack API servers.
+                        return BoltResponse(status=200)
                     else:
                         continue
                 else:
