Allow setting typed objects via PyModule.Set #2311

Activity

1. dmitry-medvedev commented on Feb 14, 2024

   

   dmitry-medvedev

   on Feb 14, 2024

   Author

   More actions

   We were able to achieve the desired effect by using the following code:

    internal static class PythonModuleExtensions
    {
        public static void Set(this PyModule module, string name, object value, Type type)
        {
            using var pyValue = Converter.ToPython(value, type);
            SetPyValue(module, name, pyValue.Borrow());
        }
   
        private static void SetPyValue(PyModule module, string name, BorrowedReference value)
        {
            Check(module);
            if (name is null)
                throw new ArgumentNullException(nameof(name));
   
            using var pyKey = new PyString(name);
   
            var result = Runtime.PyObject_SetItem(module.variables, pyKey.obj, value);
            if (result < 0)
            {
                throw PythonException.ThrowLastAsClrException();
            }
        }
   
        private static void Check(PyModule module)
        {
            if (module.Reference.IsNull)
            {
                throw new ObjectDisposedException(nameof(PyModule));
            }
        }
    }
   

   However, as some of these types/methods are internal, this is only possible if we use IgnoresAccessChecksToGenerator, which we would really like to avoid.
2. lostmsu commented on Feb 14, 2024

   

   lostmsu

   on Feb 14, 2024

   Member

   More actions

   PyModule inherits from PyObject, and PyObject has a Set method that accepts PyObject value.

   Sounds like we just need an overload for ToPython that takes type parameter. I think it would be better to have both generic and non-generic variants. PR would be welcome.

   👍React with 👍1Reacted by heartacker
3. dmitry-medvedev commented on Feb 19, 2024

   

   dmitry-medvedev

   on Feb 19, 2024

   Author

   More actions

   We've sent PR via a separate ticket:
   #2323
4. lostmsu

   added a commit that references this issue on Feb 27, 2024

   Added `ToPythonAs<T>()` extension method to allow for explicit conver…

   ...

   5be9bd5
5. filmor

   closed this as completedin #2330on Feb 28, 2024
6. filmor

   added a commit that references this issue on Feb 28, 2024

   Added `ToPythonAs<T>()` extension method to allow for explicit conver…

   ...

   9d18a24