add _Relationship value type

Steve Canny · Steve Canny · commit e43b7b96d7a6 · 2013-08-05T15:08:41.000-07:00
diff --git a/opc/package.py b/opc/package.py
@@ -129,6 +129,37 @@ class _Relationship(object):
     """
     def __init__(self, rId, reltype, target, baseURI, external=False):
         super(_Relationship, self).__init__()
+        self._rId = rId
+        self._reltype = reltype
+        self._target = target
+        self._baseURI = baseURI
+        self._is_external = bool(external)
+
+    @property
+    def is_external(self):
+        return self._is_external
+
+    @property
+    def reltype(self):
+        return self._reltype
+
+    @property
+    def rId(self):
+        return self._rId
+
+    @property
+    def target_part(self):
+        if self._is_external:
+            raise ValueError("target_part property on _Relationship is undef"
+                             "ined when target mode is External")
+        return self._target
+
+    @property
+    def target_ref(self):
+        if self._is_external:
+            return self._target
+        else:
+            return self._target.partname.relative_ref(self._baseURI)
 
 
 class RelationshipCollection(object):
diff --git a/tests/test_package.py b/tests/test_package.py
@@ -14,9 +14,10 @@
 from mock import call, Mock
 
 from opc.package import (
-    OpcPackage, Part, PartFactory, RelationshipCollection, Unmarshaller
+    OpcPackage, Part, PartFactory, _Relationship, RelationshipCollection,
+    Unmarshaller
 )
-from opc.packuri import PACKAGE_URI
+from opc.packuri import PACKAGE_URI, PackURI
 
 from .unitutil import class_mock, method_mock
 
@@ -132,6 +133,43 @@ def it_constructs_a_part_instance(self, Part_):
         assert part == Part_.return_value
 
 
+class Describe_Relationship(object):
+
+    def it_remembers_construction_values(self):
+        # test data --------------------
+        rId = 'rId9'
+        reltype = 'reltype'
+        target = Mock(name='target_part')
+        external = False
+        # exercise ---------------------
+        rel = _Relationship(rId, reltype, target, None, external)
+        # verify -----------------------
+        assert rel.rId == rId
+        assert rel.reltype == reltype
+        assert rel.target_part == target
+        assert rel.is_external == external
+
+    def it_should_raise_on_target_part_access_on_external_rel(self):
+        rel = _Relationship(None, None, None, None, external=True)
+        with pytest.raises(ValueError):
+            rel.target_part
+
+    def it_should_have_target_ref_for_external_rel(self):
+        rel = _Relationship(None, None, 'target', None, external=True)
+        assert rel.target_ref == 'target'
+
+    def it_should_have_relative_ref_for_internal_rel(self):
+        """
+        Internal relationships (TargetMode == 'Internal' in the XML) should
+        have a relative ref, e.g. '../slideLayouts/slideLayout1.xml', for
+        the target_ref attribute.
+        """
+        part = Mock(name='part', partname=PackURI('/ppt/media/image1.png'))
+        baseURI = '/ppt/slides'
+        rel = _Relationship(None, None, part, baseURI)  # external=False
+        assert rel.target_ref == '../media/image1.png'
+
+
 class DescribeRelationshipCollection(object):
 
     @pytest.fixture
