style: add _Style.style_id setter

Steve Canny · Steve Canny · commit fbc93af1f0b5 · 2015-02-08T00:01:13.000-08:00
diff --git a/docx/styles/style.py b/docx/styles/style.py
@@ -42,6 +42,10 @@ def style_id(self):
         """
         return self._element.styleId
 
+    @style_id.setter
+    def style_id(self, value):
+        self._element.styleId = value
+
 
 class _CharacterStyle(BaseStyle):
     """
diff --git a/features/sty-style-props.feature b/features/sty-style-props.feature
@@ -9,7 +9,6 @@ Feature: Get and set style properties
      Then style.style_id is the known style id
 
 
-  @wip
   Scenario: Set style id
     Given a style having a known style id
      When I assign a new value to style.style_id
diff --git a/tests/styles/test_style.py b/tests/styles/test_style.py
@@ -15,7 +15,7 @@
     StyleFactory, _TableStyle
 )
 
-from ..unitutil.cxml import element
+from ..unitutil.cxml import element, xml
 from ..unitutil.mock import class_mock, instance_mock
 
 
@@ -98,6 +98,11 @@ def it_knows_its_style_id(self, id_get_fixture):
         style, expected_value = id_get_fixture
         assert style.style_id == expected_value
 
+    def it_can_change_its_style_id(self, id_set_fixture):
+        style, new_value, expected_xml = id_set_fixture
+        style.style_id = new_value
+        assert style._element.xml == expected_xml
+
     # fixture --------------------------------------------------------
 
     @pytest.fixture(params=[
@@ -108,3 +113,15 @@ def id_get_fixture(self, request):
         style_cxml, expected_value = request.param
         style = BaseStyle(element(style_cxml))
         return style, expected_value
+
+    @pytest.fixture(params=[
+        ('w:style',                'Foo', 'w:style{w:styleId=Foo}'),
+        ('w:style{w:styleId=Foo}', 'Bar', 'w:style{w:styleId=Bar}'),
+        ('w:style{w:styleId=Bar}', None,  'w:style'),
+        ('w:style',                None,  'w:style'),
+    ])
+    def id_set_fixture(self, request):
+        style_cxml, new_value, expected_style_cxml = request.param
+        style = BaseStyle(element(style_cxml))
+        expected_xml = xml(expected_style_cxml)
+        return style, new_value, expected_xml
