Skip to content

Commit f3a2f10

Browse files
author
Steve Canny
committed
api: remove old Document.core_properties
1 parent 5ff190a commit f3a2f10

2 files changed

Lines changed: 1 addition & 20 deletions

File tree

docx/api.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,7 @@ def add_table(self, rows, cols, style='Light Shading Accent 1'):
7272

7373
@property
7474
def core_properties(self):
75-
"""
76-
A |CoreProperties| object providing read/write access to the core
77-
properties of this document.
78-
"""
79-
return self._package.core_properties
75+
return self._document.core_properties
8076

8177
@property
8278
def inline_shapes(self):

tests/test_api.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
from docx.api import Document, DocumentNew
1616
from docx.opc.constants import CONTENT_TYPE as CT, RELATIONSHIP_TYPE as RT
17-
from docx.opc.coreprops import CoreProperties
1817
from docx.package import Package
1918
from docx.parts.document import DocumentPart, InlineShapes
2019
from docx.parts.numbering import NumberingPart
@@ -112,11 +111,6 @@ def it_can_save_the_package(self, save_fixture):
112111
document.save(file_)
113112
package_.save.assert_called_once_with(file_)
114113

115-
def it_provides_access_to_its_core_properties(self, core_props_fixture):
116-
document, core_properties_ = core_props_fixture
117-
core_properties = document.core_properties
118-
assert core_properties is core_properties_
119-
120114
def it_provides_access_to_its_styles(self, styles_fixture):
121115
document, styles_ = styles_fixture
122116
styles = document.styles
@@ -142,11 +136,6 @@ def it_creates_numbering_part_on_first_access_if_not_present(
142136

143137
# fixtures -------------------------------------------------------
144138

145-
@pytest.fixture
146-
def core_props_fixture(self, document, core_properties_):
147-
document._package.core_properties = core_properties_
148-
return document, core_properties_
149-
150139
@pytest.fixture
151140
def init_fixture(self, docx_, open_):
152141
return docx_, open_
@@ -177,10 +166,6 @@ def tables_fixture(self, document, tables_):
177166

178167
# fixture components ---------------------------------------------
179168

180-
@pytest.fixture
181-
def core_properties_(self, request):
182-
return instance_mock(request, CoreProperties)
183-
184169
@pytest.fixture
185170
def Document_inline_shapes_(self, request, inline_shapes_):
186171
return property_mock(

0 commit comments

Comments
 (0)