api: remove old Document.add_page_break()

Steve Canny · Steve Canny · commit 99c713fd003b · 2015-02-14T21:52:54.000-08:00
diff --git a/docx/api.py b/docx/api.py
@@ -11,7 +11,6 @@
 import os
 
 from docx.enum.section import WD_SECTION
-from docx.enum.text import WD_BREAK
 from docx.opc.constants import CONTENT_TYPE as CT, RELATIONSHIP_TYPE as RT
 from docx.package import Package
 from docx.parts.numbering import NumberingPart
@@ -57,14 +56,7 @@ def add_heading(self, text='', level=1):
         return self._document.add_heading(text, level)
 
     def add_page_break(self):
-        """
-        Return a paragraph newly added to the end of the document and
-        containing only a page break.
-        """
-        p = self._document_part.add_paragraph()
-        r = p.add_run()
-        r.add_break(WD_BREAK.PAGE)
-        return p
+        return self._document.add_page_break()
 
     def add_paragraph(self, text='', style=None):
         return self._document.add_paragraph(text, style)
diff --git a/docx/parts/document.py b/docx/parts/document.py
@@ -25,12 +25,6 @@ class DocumentPart(XmlPart):
     """
     Main document part of a WordprocessingML (WML) package, aka a .docx file.
     """
-    def add_paragraph(self, text='', style=None):
-        """
-        Return a paragraph newly added to the end of body content.
-        """
-        return self.body.add_paragraph(text, style)
-
     def add_section(self, start_type=WD_SECTION.NEW_PAGE):
         """
         Return a |Section| object representing a new section added at the end
diff --git a/tests/parts/test_document.py b/tests/parts/test_document.py
@@ -69,12 +69,6 @@ def it_provides_access_to_the_inline_shapes_in_the_document(
         InlineShapes_.assert_called_once_with(body_elm, document)
         assert inline_shapes is InlineShapes_.return_value
 
-    def it_can_add_a_paragraph(self, add_paragraph_fixture):
-        document_part, body_, p_ = add_paragraph_fixture
-        p = document_part.add_paragraph()
-        body_.add_paragraph.assert_called_once_with('', None)
-        assert p is p_
-
     def it_can_add_a_section(self, add_section_fixture):
         (document_part, start_type_, body_elm_, new_sectPr_, Section_,
          section_) = add_section_fixture
@@ -144,11 +138,6 @@ def it_creates_default_styles_part_if_not_present_to_help(
 
     # fixtures -------------------------------------------------------
 
-    @pytest.fixture
-    def add_paragraph_fixture(self, document_part_body_, body_, p_):
-        document_part = DocumentPart(None, None, None, None)
-        return document_part, body_, p_
-
     @pytest.fixture
     def add_section_fixture(
             self, document_elm_, start_type_, body_elm_, sectPr_, Section_,
diff --git a/tests/test_api.py b/tests/test_api.py
@@ -13,7 +13,6 @@
 import docx
 
 from docx.api import Document, DocumentNew
-from docx.enum.text import WD_BREAK
 from docx.opc.constants import CONTENT_TYPE as CT, RELATIONSHIP_TYPE as RT
 from docx.opc.coreprops import CoreProperties
 from docx.package import Package
@@ -23,7 +22,6 @@
 from docx.shape import InlineShape
 from docx.styles.styles import Styles
 from docx.table import Table
-from docx.text.paragraph import Paragraph
 from docx.text.run import Run
 
 from .unitutil.mock import (
@@ -92,14 +90,6 @@ def Package_(self, request):
 
 class DescribeDocumentOld(object):
 
-    def it_can_add_a_page_break(self, add_page_break_fixture):
-        document, document_part_, paragraph_, run_ = add_page_break_fixture
-        paragraph = document.add_page_break()
-        document_part_.add_paragraph.assert_called_once_with()
-        paragraph_.add_run.assert_called_once_with()
-        run_.add_break.assert_called_once_with(WD_BREAK.PAGE)
-        assert paragraph is paragraph_
-
     def it_can_add_a_picture(self, add_picture_fixture):
         document, image_path_, width, height, run_, picture_ = (
             add_picture_fixture
@@ -177,11 +167,6 @@ def it_creates_numbering_part_on_first_access_if_not_present(
 
     # fixtures -------------------------------------------------------
 
-    @pytest.fixture
-    def add_page_break_fixture(
-            self, document, document_part_, paragraph_, run_):
-        return document, document_part_, paragraph_, run_
-
     @pytest.fixture
     def add_picture_fixture(self, request, run_, picture_):
         document = Document()
@@ -255,13 +240,10 @@ def document_obj_(self, request):
         return instance_mock(request, docx.document.Document)
 
     @pytest.fixture
-    def document_part_(
-            self, request, paragraph_, paragraphs_, section_, table_,
-            tables_):
+    def document_part_(self, request, paragraphs_, section_, table_, tables_):
         document_part_ = instance_mock(
             request, DocumentPart, content_type=CT.WML_DOCUMENT_MAIN
         )
-        document_part_.add_paragraph.return_value = paragraph_
         document_part_.add_section.return_value = section_
         document_part_.add_table.return_value = table_
         document_part_.paragraphs = paragraphs_
@@ -309,12 +291,6 @@ def package_(self, request, document_part_):
         package_.main_document_part = document_part_
         return package_
 
-    @pytest.fixture
-    def paragraph_(self, request, run_):
-        paragraph_ = instance_mock(request, Paragraph)
-        paragraph_.add_run.return_value = run_
-        return paragraph_
-
     @pytest.fixture
     def paragraphs_(self, request):
         return instance_mock(request, list)
