style: remove dead Document.styles_part and tests

Steve Canny · Steve Canny · commit 587a8a319afd · 2015-02-08T00:00:06.000-08:00
diff --git a/docx/api.py b/docx/api.py
@@ -15,7 +15,6 @@
 from docx.opc.constants import CONTENT_TYPE as CT, RELATIONSHIP_TYPE as RT
 from docx.package import Package
 from docx.parts.numbering import NumberingPart
-from docx.parts.styles import StylesPart
 from docx.shared import lazyproperty
 
 
@@ -166,19 +165,6 @@ def styles(self):
         """
         return self._document_part.styles
 
-    @lazyproperty
-    def styles_part(self):
-        """
-        Instance of |StylesPart| for this document. Creates an empty styles
-        part if one is not present.
-        """
-        try:
-            return self._document_part.part_related_by(RT.STYLES)
-        except KeyError:
-            styles_part = StylesPart.new()
-            self._document_part.relate_to(styles_part, RT.STYLES)
-            return styles_part
-
     @property
     def tables(self):
         """
diff --git a/docx/parts/styles.py b/docx/parts/styles.py
@@ -25,14 +25,6 @@ def default(cls, package):
         """
         raise NotImplementedError
 
-    @classmethod
-    def new(cls):
-        """
-        Return newly created empty styles part, containing only the root
-        ``<w:styles>`` element.
-        """
-        raise NotImplementedError
-
     @property
     def styles(self):
         """
diff --git a/features/steps/styles.py b/features/steps/styles.py
@@ -4,7 +4,7 @@
 Step implementations for styles-related features
 """
 
-from behave import given, then, when
+from behave import given, then
 
 from docx import Document
 from docx.styles.styles import Styles
@@ -27,14 +27,6 @@ def given_a_document_having_no_styles_part(context):
     context.document = Document(docx_path)
 
 
-# when ====================================================
-
-@when('I get the styles part from the document')
-def when_get_styles_part_from_document(context):
-    document = context.document
-    context.styles_part = document.styles_part
-
-
 # then =====================================================
 
 @then('I can access a style by its UI name')
@@ -68,9 +60,3 @@ def then_I_can_iterate_over_its_styles(context):
 @then('len(styles) is {style_count_str}')
 def then_len_styles_is_style_count(context, style_count_str):
     assert len(context.document.styles) == int(style_count_str)
-
-
-@then('the styles part has the expected number of style definitions')
-def then_styles_part_has_expected_number_of_style_definitions(context):
-    styles_part = context.styles_part
-    assert len(styles_part.styles) == 6
diff --git a/features/sty-get-styles-part.feature b/features/sty-get-styles-part.feature
diff --git a/tests/test_api.py b/tests/test_api.py
@@ -17,7 +17,6 @@
 from docx.package import Package
 from docx.parts.document import DocumentPart, InlineShapes
 from docx.parts.numbering import NumberingPart
-from docx.parts.styles import StylesPart
 from docx.section import Section
 from docx.shape import InlineShape
 from docx.styles.styles import Styles
@@ -134,7 +133,7 @@ def it_can_save_the_package(self, save_fixture):
         document.save(file_)
         package_.save.assert_called_once_with(file_)
 
-    def it_provides_access_to_the_core_properties(self, core_props_fixture):
+    def it_provides_access_to_its_core_properties(self, core_props_fixture):
         document, core_properties_ = core_props_fixture
         core_properties = document.core_properties
         assert core_properties is core_properties_
@@ -162,24 +161,6 @@ def it_creates_numbering_part_on_first_access_if_not_present(
         )
         assert numbering_part is numbering_part_
 
-    def it_provides_access_to_the_styles_part(self, styles_part_get_fixture):
-        document, document_part_, styles_part_ = styles_part_get_fixture
-        styles_part = document.styles_part
-        document_part_.part_related_by.assert_called_once_with(RT.STYLES)
-        assert styles_part is styles_part_
-
-    def it_creates_styles_part_on_first_access_if_not_present(
-            self, styles_part_create_fixture):
-        document, StylesPart_, document_part_, styles_part_ = (
-            styles_part_create_fixture
-        )
-        styles_part = document.styles_part
-        StylesPart_.new.assert_called_once_with()
-        document_part_.relate_to.assert_called_once_with(
-            styles_part_, RT.STYLES
-        )
-        assert styles_part is styles_part_
-
     # fixtures -------------------------------------------------------
 
     @pytest.fixture(params=[
@@ -377,27 +358,6 @@ def start_type_(self, request):
     def styles_(self, request):
         return instance_mock(request, Styles)
 
-    @pytest.fixture
-    def StylesPart_(self, request, styles_part_):
-        StylesPart_ = class_mock(request, 'docx.api.StylesPart')
-        StylesPart_.new.return_value = styles_part_
-        return StylesPart_
-
-    @pytest.fixture
-    def styles_part_(self, request):
-        return instance_mock(request, StylesPart)
-
-    @pytest.fixture
-    def styles_part_create_fixture(
-            self, document, StylesPart_, document_part_, styles_part_):
-        document_part_.part_related_by.side_effect = KeyError
-        return document, StylesPart_, document_part_, styles_part_
-
-    @pytest.fixture
-    def styles_part_get_fixture(self, document, document_part_, styles_part_):
-        document_part_.part_related_by.return_value = styles_part_
-        return document, document_part_, styles_part_
-
     @pytest.fixture
     def table_(self, request):
         return instance_mock(request, Table, style=None)
