style: add BaseStyle.hidden setter

Steve Canny · Steve Canny · commit 0b895866e568 · 2015-02-08T00:01:45.000-08:00
diff --git a/docx/oxml/styles.py b/docx/oxml/styles.py
@@ -118,6 +118,13 @@ def semiHidden_val(self):
             return False
         return semiHidden.val
 
+    @semiHidden_val.setter
+    def semiHidden_val(self, value):
+        self._remove_semiHidden()
+        if bool(value) is True:
+            semiHidden = self._add_semiHidden()
+            semiHidden.val = value
+
 
 class CT_Styles(BaseOxmlElement):
     """
diff --git a/docx/styles/style.py b/docx/styles/style.py
@@ -69,6 +69,10 @@ def hidden(self):
         """
         return self._element.semiHidden_val
 
+    @hidden.setter
+    def hidden(self, value):
+        self._element.semiHidden_val = value
+
     @property
     def name(self):
         """
diff --git a/features/sty-style-props.feature b/features/sty-style-props.feature
@@ -37,7 +37,6 @@ Feature: Get and set style properties
       | no setting | False |
 
 
-  @wip
   Scenario Outline: Set hidden value
     Given a style having hidden set <setting>
      When I assign <new-value> to style.hidden
diff --git a/tests/styles/test_style.py b/tests/styles/test_style.py
@@ -127,6 +127,11 @@ def it_knows_whether_its_hidden(self, hidden_get_fixture):
         style, expected_value = hidden_get_fixture
         assert style.hidden == expected_value
 
+    def it_can_change_whether_its_hidden(self, hidden_set_fixture):
+        style, value, expected_xml = hidden_set_fixture
+        style.hidden = value
+        assert style._element.xml == expected_xml
+
     def it_can_delete_itself_from_the_document(self, delete_fixture):
         style, styles, expected_xml = delete_fixture
         style.delete()
@@ -163,6 +168,20 @@ def hidden_get_fixture(self, request):
         style = BaseStyle(element(style_cxml))
         return style, expected_value
 
+    @pytest.fixture(params=[
+        ('w:style',                       True,  'w:style/w:semiHidden'),
+        ('w:style/w:semiHidden{w:val=0}', True,  'w:style/w:semiHidden'),
+        ('w:style/w:semiHidden{w:val=1}', True,  'w:style/w:semiHidden'),
+        ('w:style',                       False, 'w:style'),
+        ('w:style/w:semiHidden',          False, 'w:style'),
+        ('w:style/w:semiHidden{w:val=1}', False, 'w:style'),
+    ])
+    def hidden_set_fixture(self, request):
+        style_cxml, value, expected_cxml = request.param
+        style = BaseStyle(element(style_cxml))
+        expected_xml = xml(expected_cxml)
+        return style, value, expected_xml
+
     @pytest.fixture(params=[
         ('w:style',                   None),
         ('w:style{w:styleId=Foobar}', 'Foobar'),
