Issue #29044: Fix a use-after-free in string '%c' formatter.

zhangyangyu · zhangyangyu · commit d04fa29c7556 · 2016-12-22T15:30:47.000+08:00
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -14213,11 +14213,12 @@ formatchar(PyObject *v)
             if (iobj == NULL) {
                 goto onError;
             }
-            v = iobj;
+            x = PyLong_AsLong(iobj);
             Py_DECREF(iobj);
         }
-        /* Integer input truncated to a character */
-        x = PyLong_AsLong(v);
+        else {
+            x = PyLong_AsLong(v);
+        }
         if (x == -1 && PyErr_Occurred())
             goto onError;
 
