- Issue #16593: Have BSD 'make -s' do the right thing, thanks to Daniel Shahaf

tiran · tiran · commit 97512345c48b · 2012-12-02T08:14:50.000+01:00
diff --git a/Makefile.pre.in b/Makefile.pre.in
@@ -441,11 +441,12 @@ platform: $(BUILDPYTHON)
 
 
 # Build the shared modules
-# MAKEFLAGS are sorted and normalized. Under GNU make the 's' for
+# Under GNU make, MAKEFLAGS are sorted and normalized; the 's' for
 # -s, --silent or --quiet is always the first char.
+# Under BSD make, MAKEFLAGS might be " -s -v x=y".
 sharedmods: $(BUILDPYTHON)
 	@case "$$MAKEFLAGS" in \
-	    s*) quiet="-q";; \
+	    *\ -s*|s*) quiet="-q";; \
 	    *) quiet="";; \
 	esac; \
 	$(RUNSHARED) CC='$(CC)' LDSHARED='$(BLDSHARED)' OPT='$(OPT)' \
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -706,6 +706,8 @@ Tests
 Build
 -----
 
+- Issue #16593: Have BSD 'make -s' do the right thing, thanks to Daniel Shahaf
+
 - Issue #16262: fix out-of-src-tree builds, if mercurial is not installed.
 
 - Issue #15923: fix a mistake in asdl_c.py that resulted in a TypeError after
