Py_TYPE() has already dereferenced self before the NULL check. Moved Py_TYPE() after the check for self == NULL

tiran · tiran · commit 1f4e9274dfa9 · 2012-09-10T02:45:31.000+02:00
diff --git a/Objects/classobject.c b/Objects/classobject.c
@@ -218,14 +218,15 @@ method_repr(PyMethodObject *a)
 {
     PyObject *self = a->im_self;
     PyObject *func = a->im_func;
-    PyObject *klass = (PyObject*)Py_TYPE(self);
+    PyObject *klass;
     PyObject *funcname = NULL ,*klassname = NULL, *result = NULL;
     char *defname = "?";
 
     if (self == NULL) {
         PyErr_BadInternalCall();
         return NULL;
     }
+    klass = (PyObject*)Py_TYPE(self);
 
     funcname = PyObject_GetAttrString(func, "__name__");
     if (funcname == NULL) {
