prevent infinite recursion of post-checkout on clone

asottile · asottile · commit 6ee9e13b2686 · 2020-06-09T10:18:22.000-07:00
diff --git a/pre_commit/git.py b/pre_commit/git.py
@@ -158,7 +158,8 @@ def init_repo(path: str, remote: str) -> None:
         remote = os.path.abspath(remote)
 
     env = no_git_env()
-    cmd_output_b('git', 'init', path, env=env)
+    # avoid the user's template so that hooks do not recurse
+    cmd_output_b('git', 'init', '--template=', path, env=env)
     cmd_output_b('git', 'remote', 'add', 'origin', remote, cwd=path, env=env)
 
 
diff --git a/tests/git_test.py b/tests/git_test.py
@@ -186,3 +186,8 @@ def test_no_git_env():
         'GIT_SSH': '/usr/bin/ssh',
         'GIT_SSH_COMMAND': 'ssh -o',
     }
+
+
+def test_init_repo_no_hooks(tmpdir):
+    git.init_repo(str(tmpdir), remote='dne')
+    assert not tmpdir.join('.git/hooks').exists()

Original file line number	Diff line number	Diff line change
`@@ -186,3 +186,8 @@ def test_no_git_env():`
`186`	`186`	`'GIT_SSH': '/usr/bin/ssh',`
`187`	`187`	`'GIT_SSH_COMMAND': 'ssh -o',`
`188`	`188`	`}`
	`189`	`+`
	`190`	`+`
	`191`	`+def test_init_repo_no_hooks(tmpdir):`
	`192`	`+ git.init_repo(str(tmpdir), remote='dne')`
	`193`	`+ assert not tmpdir.join('.git/hooks').exists()`