fix(mypy): fixed mypy issues

pythonhubdev · pythonhubdev · commit 8e54ab03970e · 2024-06-29T16:25:41.000+05:30
diff --git a/examples/config.py b/examples/config.py
@@ -1,13 +1,14 @@
 from functools import lru_cache
+from typing import Optional
 
 from pydantic_settings import BaseSettings, SettingsConfigDict
 
 
 # Create configuration with pydantic BaseSettings https://pydantic-docs.helpmanual.io/usage/settings/.
 class Config(BaseSettings):
-    notion_secret_token: str
-    database_id: str
-    page_id: str
+    notion_secret_token: str = ""
+    database_id: str = ""
+    page_id: str = ""
 
     model_config = SettingsConfigDict(
         env_file=".env",
diff --git a/examples/database/create_database.py b/examples/database/create_database.py
@@ -81,8 +81,11 @@
     properties=properties,
 )
 
-response: CreateDatabaseResponseSchema = py_notion_client.database.create_database(
+response: CreateDatabaseResponseSchema | str = py_notion_client.database.create_database(
     payload=create_database_payload,
 )
 
-print(response.model_dump_json(indent=4))
+if isinstance(response, str):
+    print(response)
+else:
+    print(response.model_dump_json(indent=4))
diff --git a/examples/database/query_database.py b/examples/database/query_database.py
@@ -18,11 +18,11 @@
 property_filter = PropertyFilter(property="Name", rich_text=rich_text_filter)
 filter_object = Filter(page_size=100, filter=property_filter)
 
-response_dict_payload: NotionDatabaseResponseSchema = py_notion_client.database.query_database(
+response_dict_payload: NotionDatabaseResponseSchema | str = py_notion_client.database.query_database(
     database_id=base_config.database_id,
     payload=filter_dict,
 )
-response_filter_payload: NotionDatabaseResponseSchema = py_notion_client.database.query_database(
+response_filter_payload: NotionDatabaseResponseSchema | str = py_notion_client.database.query_database(
     database_id=base_config.database_id,
     payload=filter_object,
 )
@@ -32,9 +32,14 @@
 # Inside the properties use the key name you gave for each table in your database to access the value.
 # For example: CustomizedSelect is the key name for the table named "CustomizedSelect" in my database.
 
-print(
-    response_dict_payload.results[0].properties.Name.json(indent=4),
-)  # Print the first result's Select property as json.
-print(
-    response_filter_payload.results[0].properties.Name.json(indent=4),
-)  # Print the first result's Select property as json.
+if isinstance(response_dict_payload, str):
+    print(response_dict_payload)
+
+if isinstance(response_dict_payload, NotionDatabaseResponseSchema):
+    print(
+        response_dict_payload.results[0].properties.Name.json(indent=4),
+    )  # Print the first result's Select property as json.
+if isinstance(response_filter_payload, NotionDatabaseResponseSchema):
+    print(
+        response_filter_payload.results[0].properties.Name.json(indent=4),
+    )  # Print the first result's Select property as json.
diff --git a/pynotionclient/schema/database/response/rich_text_filter_schema.py b/pynotionclient/schema/database/response/rich_text_filter_schema.py
@@ -4,5 +4,5 @@
 
 
 class RichTextFilter(ContainsFilter, EqualsFilter, EmptyFilter):
-    starts_with: Optional[str]
-    ends_with: Optional[str]
+    starts_with: Optional[str] = None
+    ends_with: Optional[str] = None

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,11 @@`
`81`	`81`	`properties=properties,`
`82`	`82`	`)`
`83`	`83`
`84`		`-response: CreateDatabaseResponseSchema = py_notion_client.database.create_database(`
	`84`	`+response: CreateDatabaseResponseSchema \| str = py_notion_client.database.create_database(`
`85`	`85`	`payload=create_database_payload,`
`86`	`86`	`)`
`87`	`87`
`88`		`-print(response.model_dump_json(indent=4))`
	`88`	`+if isinstance(response, str):`
	`89`	`+ print(response)`
	`90`	`+else:`
	`91`	`+ print(response.model_dump_json(indent=4))`