Skip to content

Commit c137e3d

Browse files
committed
src: Remove unused refs to node_object_wrap.h
Turns out that we don't use node_object_wrap.h any more in core, and, with v8 3.21, it's breaking our Windows build. Removing refs to it everywhere (and adding node.h in one case where it was the only way node.h was being included), we have restored the Windows build.
1 parent f755ecf commit c137e3d

4 files changed

Lines changed: 1 addition & 5 deletions

File tree

src/node.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060

6161
#include "v8.h" // NOLINT(build/include_order)
6262
#include "node_version.h" // NODE_MODULE_VERSION
63-
#include "node_object_wrap.h"
6463

6564
// Forward-declare these functions now to stop MSVS from becoming
6665
// terminally confused when it's done in node_internals.h

src/node_contextify.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#define SRC_NODE_CONTEXTIFY_H_
2424

2525
#include "node.h"
26-
#include "node_object_wrap.h"
2726
#include "v8.h"
2827
#include "uv.h"
2928

src/node_crypto.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#include "node.h"
2626
#include "node_crypto_clienthello.h" // ClientHelloParser
2727
#include "node_crypto_clienthello-inl.h"
28-
#include "node_object_wrap.h"
2928

3029
#ifdef OPENSSL_NPN_NEGOTIATED
3130
#include "node_buffer.h"

src/node_stat_watcher.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@
2222
#ifndef SRC_NODE_STAT_WATCHER_H_
2323
#define SRC_NODE_STAT_WATCHER_H_
2424

25-
#include "node_object_wrap.h"
26-
2725
#include "env.h"
26+
#include "node.h"
2827
#include "uv.h"
2928
#include "v8.h"
3029
#include "weak-object.h"

0 commit comments

Comments
 (0)