Skip to content

Commit 1172da6

Browse files
committed
Update v3/docs/opt-trace-format.md
1 parent 502a185 commit 1172da6

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

v3/docs/opt-trace-format.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -732,10 +732,10 @@ during execution. The global analogue for this field is `ordered_globals`. (I su
732732
`frame_id` is a unique integer that identifies this frame; the first executed function gets an ID of 1, and then
733733
subsequent calls get successively increasing IDs.
734734

735-
`unique_hash` is a unique string that identifies this frame. At this point, I don't remember clearly why
736-
this field is required in addition to `frame_id`, but nonetheless the frontend depends on it. A simple way
735+
`unique_hash` is a unique string that identifies this frame. For now, a simple way
737736
to construct `unique_hash` is by concatenating the frame's function name with `frame_id`.
738-
(There's probably some subtle thing I'm forgetting at the moment, though ...)
737+
Note that `unique_hash` seems redundant with `frame_id`, since the latter is already unique.
738+
However, you'll see in the "Closures and Zombie Frames" section why `unique_hash` is required.
739739

740740
Finally, ignore `is_parent`, `is_zombie`, and `parent_frame_id_list` for now. We'll cover those in the more advanced
741741
"Closures and Zombie Frames" section below.
@@ -744,3 +744,6 @@ Finally, ignore `is_parent`, `is_zombie`, and `parent_frame_id_list` for now. We
744744
## Closures and Zombie Frames (advanced)
745745

746746
(TODO: WRITE ME!)
747+
748+
(TODO: talk about needing to append a '_p' and '_z' onto `unique_hash` when a frame becomes a parent or zombie,
749+
respectively, since the frontend needs to know when to refresh the display.)

0 commit comments

Comments
 (0)