Skip to content

Commit ff39df8

Browse files
zzzckckzzzckck
authored
Implement BEP-592: Non-Consensus Based Block-Level Access List (bnb-chain#3374)
1 parent 8c16625 commit ff39df8

37 files changed

Lines changed: 1557 additions & 34 deletions

‎cmd/geth/main.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ var (
146146
utils.MinerRecommitIntervalFlag,
147147
utils.MinerNewPayloadTimeoutFlag, // deprecated
148148
utils.MinerDelayLeftoverFlag,
149+
utils.EnableBALFlag,
149150
// utils.MinerNewPayloadTimeout,
150151
utils.NATFlag,
151152
utils.NoDiscoverFlag,

‎cmd/utils/flags.go‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,11 @@ var (
182182
Usage: "Chapel network: pre-configured Proof-of-Stake-Authority BSC test network",
183183
Category: flags.EthCategory,
184184
}
185+
EnableBALFlag = &cli.BoolFlag{
186+
Name: "enablebal",
187+
Usage: "Enable block access list feature, validator will generate BAL for each block",
188+
Category: flags.EthCategory,
189+
}
185190
// Dev mode
186191
DeveloperFlag = &cli.BoolFlag{
187192
Name: "dev",
@@ -1743,6 +1748,9 @@ func SetNodeConfig(ctx *cli.Context, cfg *node.Config) {
17431748
if ctx.IsSet(DisableSnapProtocolFlag.Name) {
17441749
cfg.DisableSnapProtocol = ctx.Bool(DisableSnapProtocolFlag.Name)
17451750
}
1751+
if ctx.IsSet(EnableBALFlag.Name) {
1752+
cfg.EnableBAL = ctx.Bool(EnableBALFlag.Name)
1753+
}
17461754
if ctx.IsSet(RangeLimitFlag.Name) {
17471755
cfg.RangeLimit = ctx.Bool(RangeLimitFlag.Name)
17481756
}
@@ -2042,6 +2050,9 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
20422050
if ctx.IsSet(CacheNoPrefetchFlag.Name) {
20432051
cfg.NoPrefetch = ctx.Bool(CacheNoPrefetchFlag.Name)
20442052
}
2053+
if ctx.IsSet(EnableBALFlag.Name) {
2054+
cfg.EnableBAL = ctx.Bool(EnableBALFlag.Name)
2055+
}
20452056
// Read the value from the flag no matter if it's set or not.
20462057
cfg.Preimages = ctx.Bool(CachePreimagesFlag.Name)
20472058
if cfg.NoPruning && !cfg.Preimages {
@@ -2697,6 +2708,7 @@ func MakeChain(ctx *cli.Context, stack *node.Node, readonly bool) (*core.BlockCh
26972708
options := &core.BlockChainConfig{
26982709
TrieCleanLimit: ethconfig.Defaults.TrieCleanCache,
26992710
NoPrefetch: ctx.Bool(CacheNoPrefetchFlag.Name),
2711+
EnableBAL: ctx.Bool(EnableBALFlag.Name),
27002712
TrieDirtyLimit: ethconfig.Defaults.TrieDirtyCache,
27012713
ArchiveMode: ctx.String(GCModeFlag.Name) == "archive",
27022714
TrieTimeLimit: ethconfig.Defaults.TrieTimeout,

‎consensus/beacon/consensus.go‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,15 @@ func (beacon *Beacon) SealHash(header *types.Header) common.Hash {
491491
return beacon.ethone.SealHash(header)
492492
}
493493

494+
func (beacon *Beacon) SignBAL(blockAccessList *types.BlockAccessListEncode) error {
495+
return nil
496+
}
497+
498+
// VerifyBAL verifies the BAL of the block
499+
func (beacon *Beacon) VerifyBAL(block *types.Block, bal *types.BlockAccessListEncode) error {
500+
return nil
501+
}
502+
494503
// CalcDifficulty is the difficulty adjustment algorithm. It returns
495504
// the difficulty that a new block should have when created at time
496505
// given the parent block's time and difficulty.

‎consensus/clique/clique.go‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -787,3 +787,11 @@ func encodeSigHeader(w io.Writer, header *types.Header) {
787787
panic("can't encode: " + err.Error())
788788
}
789789
}
790+
791+
func (c *Clique) SignBAL(bal *types.BlockAccessListEncode) error {
792+
return nil
793+
}
794+
795+
func (c *Clique) VerifyBAL(block *types.Block, bal *types.BlockAccessListEncode) error {
796+
return nil
797+
}

‎consensus/consensus.go‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,12 @@ type Engine interface {
136136
// SealHash returns the hash of a block prior to it being sealed.
137137
SealHash(header *types.Header) common.Hash
138138

139+
// SignBAL signs the BAL of the block
140+
SignBAL(blockAccessList *types.BlockAccessListEncode) error
141+
142+
// VerifyBAL verifies the BAL of the block
143+
VerifyBAL(block *types.Block, bal *types.BlockAccessListEncode) error
144+
139145
// CalcDifficulty is the difficulty adjustment algorithm. It returns the difficulty
140146
// that a new block should have.
141147
CalcDifficulty(chain ChainHeaderReader, time uint64, parent *types.Header) *big.Int

‎consensus/ethash/ethash.go‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,11 @@ func (ethash *Ethash) Close() error {
7676
func (ethash *Ethash) Seal(chain consensus.ChainHeaderReader, block *types.Block, results chan<- *types.Block, stop <-chan struct{}) error {
7777
panic("ethash (pow) sealing not supported any more")
7878
}
79+
80+
func (ethash *Ethash) SignBAL(bal *types.BlockAccessListEncode) error {
81+
return nil
82+
}
83+
84+
func (ethash *Ethash) VerifyBAL(block *types.Block, bal *types.BlockAccessListEncode) error {
85+
return nil
86+
}

‎consensus/parlia/parlia.go‎

Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1758,6 +1758,71 @@ func (p *Parlia) Seal(chain consensus.ChainHeaderReader, block *types.Block, res
17581758
return nil
17591759
}
17601760

1761+
func (p *Parlia) SignBAL(blockAccessList *types.BlockAccessListEncode) error {
1762+
p.lock.RLock()
1763+
val, signFn := p.val, p.signFn
1764+
p.lock.RUnlock()
1765+
1766+
data, err := rlp.EncodeToBytes([]interface{}{blockAccessList.Version, blockAccessList.Number, blockAccessList.Hash, blockAccessList.Accounts})
1767+
if err != nil {
1768+
log.Error("Encode to bytes failed when sealing", "err", err)
1769+
return errors.New("encode to bytes failed")
1770+
}
1771+
1772+
if len(data) > int(params.MaxBALSize) {
1773+
log.Error("data is too large", "dataSize", len(data), "maxSize", params.MaxBALSize)
1774+
return errors.New("data is too large")
1775+
}
1776+
1777+
sig, err := signFn(accounts.Account{Address: val}, accounts.MimetypeParlia, data)
1778+
if err != nil {
1779+
log.Error("Sign for the block header failed when sealing", "err", err)
1780+
return errors.New("sign for the block header failed")
1781+
}
1782+
1783+
copy(blockAccessList.SignData, sig)
1784+
return nil
1785+
}
1786+
1787+
func (p *Parlia) VerifyBAL(block *types.Block, bal *types.BlockAccessListEncode) error {
1788+
if bal.Version != 0 {
1789+
log.Error("invalid BAL version", "version", bal.Version)
1790+
return errors.New("invalid BAL version")
1791+
}
1792+
1793+
if len(bal.SignData) != 65 {
1794+
log.Error("invalid BAL signature", "signatureSize", len(bal.SignData))
1795+
return errors.New("invalid BAL signature")
1796+
}
1797+
1798+
// Recover the public key and the Ethereum address
1799+
data, err := rlp.EncodeToBytes([]interface{}{bal.Version, block.Number(), block.Hash(), bal.Accounts})
1800+
if err != nil {
1801+
log.Error("encode to bytes failed", "err", err)
1802+
return errors.New("encode to bytes failed")
1803+
}
1804+
1805+
if len(data) > int(params.MaxBALSize) {
1806+
log.Error("data is too large", "dataSize", len(data), "maxSize", params.MaxBALSize)
1807+
return errors.New("data is too large")
1808+
}
1809+
1810+
pubkey, err := crypto.Ecrecover(crypto.Keccak256(data), bal.SignData)
1811+
if err != nil {
1812+
return err
1813+
}
1814+
var pubkeyAddr common.Address
1815+
copy(pubkeyAddr[:], crypto.Keccak256(pubkey[1:])[12:])
1816+
1817+
signer := block.Header().Coinbase
1818+
if signer != pubkeyAddr {
1819+
log.Error("BAL signer mismatch", "signer", signer, "pubkeyAddr", pubkeyAddr, "bal.Number", bal.Number, "bal.Hash", bal.Hash)
1820+
return errors.New("signer mismatch")
1821+
}
1822+
1823+
return nil
1824+
}
1825+
17611826
func (p *Parlia) shouldWaitForCurrentBlockProcess(chain consensus.ChainHeaderReader, header *types.Header, snap *Snapshot) bool {
17621827
if header.Difficulty.Cmp(diffInTurn) == 0 {
17631828
return false

0 commit comments

Comments
 (0)