Fix $interfaceIsEqual general handling of two *js.Object.

dmitshur · dmitshur · commit 0bfcd10ef2a8 · 2015-06-09T01:07:04.000-07:00
Commit cb553f3 fixes the issue for when both *js.Object were undefined. This change makes that fix general and apply when the value of the two *js.Object is anything.
diff --git a/compiler/prelude/prelude.go b/compiler/prelude/prelude.go
@@ -413,9 +413,8 @@ var $interfaceIsEqual = function(a, b) {
   if (a.constructor !== b.constructor) {
     return false;
   }
-  if (a.constructor === $jsObjectPtr && a.object === undefined &&
-      b.constructor === $jsObjectPtr && b.object === undefined) {
-    return true;
+  if (a.constructor === $jsObjectPtr) {
+    return a.object === b.object;
   }
   if (!a.constructor.comparable) {
     $throwRuntimeError("comparing uncomparable type " + a.constructor.string);
diff --git a/js/js_test.go b/js/js_test.go
@@ -309,6 +309,14 @@ func TestUndefinedEquality(t *testing.T) {
 	}
 }
 
+func TestInterfaceEquality(t *testing.T) {
+	o := js.Global.Get("Object").New()
+	var i interface{} = o
+	if i != o {
+		t.Fail()
+	}
+}
+
 func TestUndefinedInternalization(t *testing.T) {
 	undefinedEqualsJsUndefined := func(i interface{}) bool {
 		return i == js.Undefined

Original file line number	Diff line number	Diff line change
`@@ -413,9 +413,8 @@ var $interfaceIsEqual = function(a, b) {`
`413`	`413`	`if (a.constructor !== b.constructor) {`
`414`	`414`	`return false;`
`415`	`415`	`}`
`416`		`- if (a.constructor === $jsObjectPtr && a.object === undefined &&`
`417`		`- b.constructor === $jsObjectPtr && b.object === undefined) {`
`418`		`- return true;`
	`416`	`+ if (a.constructor === $jsObjectPtr) {`
	`417`	`+ return a.object === b.object;`
`419`	`418`	`}`
`420`	`419`	`if (!a.constructor.comparable) {`
`421`	`420`	`$throwRuntimeError("comparing uncomparable type " + a.constructor.string);`
Original file line number	Diff line number	Diff line change
`@@ -309,6 +309,14 @@ func TestUndefinedEquality(t *testing.T) {`
`309`	`309`	`}`
`310`	`310`	`}`
`311`	`311`
	`312`	`+func TestInterfaceEquality(t *testing.T) {`
	`313`	`+ o := js.Global.Get("Object").New()`
	`314`	`+ var i interface{} = o`
	`315`	`+ if i != o {`
	`316`	`+ t.Fail()`
	`317`	`+ }`
	`318`	`+}`
	`319`	`+`
`312`	`320`	`func TestUndefinedInternalization(t *testing.T) {`
`313`	`321`	`undefinedEqualsJsUndefined := func(i interface{}) bool {`
`314`	`322`	`return i == js.Undefined`