From af2a8bac352a1a9e529c8e9ab0409562dc8cf1ff Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 22 Sep 2021 22:23:49 -0500 Subject: [PATCH] Refactor service registry to avoid use of getattr --- zeroconf/_services/registry.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/zeroconf/_services/registry.py b/zeroconf/_services/registry.py index 4e64c8d7b..203b3b396 100644 --- a/zeroconf/_services/registry.py +++ b/zeroconf/_services/registry.py @@ -69,15 +69,15 @@ def async_get_types(self) -> List[str]: def async_get_infos_type(self, type_: str) -> List[ServiceInfo]: """Return all ServiceInfo matching type.""" - return self._async_get_by_index("types", type_) + return self._async_get_by_index(self.types, type_) def async_get_infos_server(self, server: str) -> List[ServiceInfo]: """Return all ServiceInfo matching server.""" - return self._async_get_by_index("servers", server) + return self._async_get_by_index(self.servers, server) - def _async_get_by_index(self, attr: str, key: str) -> List[ServiceInfo]: + def _async_get_by_index(self, records: Dict[str, List], key: str) -> List[ServiceInfo]: """Return all ServiceInfo matching the index.""" - return [self._services[name] for name in getattr(self, attr).get(key.lower(), [])] + return [self._services[name] for name in records.get(key.lower(), [])] def _add(self, info: ServiceInfo) -> None: """Add a new service under the lock."""