Only wake up the query loop when there is a change in the next query time#818
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
==========================================
+ Coverage 98.61% 98.62% +0.01%
==========================================
Files 22 22
Lines 2303 2328 +25
Branches 395 396 +1
==========================================
+ Hits 2271 2296 +25
Misses 21 21
Partials 11 11
Continue to review full report at Codecov.
|
Member
Author
|
While this is much better and reliable, the scheduling is still sub-optimal because we will schedule a query in the future when a PTR will be close to expiring, but if the PTR is seen again between when it was scheduled and we ask again, we still ask. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ServiceBrowser query loop (async_browser_task) was being awoken on
every packet because it was using
zeroconf.async_waitwhich wakesup on every new packet. We only need to awaken the loop when the next time
we are going to send a query has changed.
fixes #814 fixes #768