Skip to content

Fix lookup of uppercase names in registry#597

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:service_registry_upper_case_fix
Jun 14, 2021
Merged

Fix lookup of uppercase names in registry#597
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:service_registry_upper_case_fix

Conversation

@bdraco

@bdraco bdraco commented Jun 13, 2021

Copy link
Copy Markdown
Member
  • If the ServiceInfo was registered with an uppercase name and the query was
    for a lowercase name, it would not be found and vice-versa.

fixes #596

@codecov-commenter

codecov-commenter commented Jun 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #597 (025ed81) into master (d2d8262) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   95.17%   95.12%   -0.06%     
==========================================
  Files          18       18              
  Lines        1948     1947       -1     
  Branches      346      346              
==========================================
- Hits         1854     1852       -2     
  Misses         52       52              
- Partials       42       43       +1     
Impacted Files Coverage Δ
zeroconf/_handlers.py 96.61% <100.00%> (-0.03%) ⬇️
zeroconf/_services/registry.py 98.00% <100.00%> (ø)
zeroconf/_services/__init__.py 92.96% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d8262...025ed81. Read the comment docs.

@bdraco bdraco merged commit fe72524 into python-zeroconf:master Jun 14, 2021
@bdraco bdraco deleted the service_registry_upper_case_fix branch June 14, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ServiceRegistry lookups fail by server/type if the service info is registered with an upper case name

2 participants