Add additional recommended records to PTR responses#184
Merged
Conversation
RFC6763 indicates a server should include the SRV/TXT/A/AAAA records when responding to a PTR record request. This optimization ensures the client doesn't have to then query for these additional records. It has been observed that when multiple Windows 10 machines are monitoring for the same service, this unoptimized response to the PTR record request can cause extremely high CPU usage in both the DHCP Client & Device Association service (I suspect due to all clients having to then sending/receiving the additional queries/responses).
Collaborator
|
This seems like a sensible thing to do, thank you for the patch. Would you mind writing a test for this behavior? |
Includes linter fixes too.
Author
|
Great. Second patch includes the testcase & a lint fix. |
Collaborator
|
Awesome, cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC6763 indicates a server should include the SRV/TXT/A/AAAA records
when responding to a PTR record request. This optimization ensures
the client doesn't have to then query for these additional records.
It has been observed that when multiple Windows 10 machines are monitoring
for the same service, this unoptimized response to the PTR record
request can cause extremely high CPU usage in both the DHCP Client
& Device Association service (I suspect due to all clients having to
then sending/receiving the additional queries/responses).