chore: enable ruff SIM108, SIM102, SIM202 in tests#1687
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1687 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3407 3407
Branches 463 463
=======================================
Hits 3399 3399
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the per-test ignores for
SIM108(use ternary),SIM102(combine nestedif), andSIM202(use==instead ofnot !=); fixes the six existing violations they surfaced. The twoSIM202sites intest_dns.pyare testing__ne__directly, so they're rewritten as(x != x) is Falseto preserve intent without tripping the rule.