Skip to content

test: fix flaky test_run_coro_with_timeout #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 2 commits into from
May 16, 2026
Merged

test: fix flaky test_run_coro_with_timeout #1683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79311dd
test: fix flaky test_run_coro_with_timeout
bluetoothbot May 16, 2026
fc99d27
test: use asyncio.Event in test_run_coro_with_timeout to unblock loop
bluetoothbot May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/utils/test_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,19 +123,25 @@ async def test_run_coro_with_timeout() -> None:
"""Test running a coroutine with a timeout raises EventLoopBlocked."""
loop = asyncio.get_event_loop()
task: asyncio.Task | None = None
task_created = asyncio.Event()

async def _saved_sleep_task():
nonlocal task
task = asyncio.create_task(asyncio.sleep(0.2))
assert task is not None
task = asyncio.create_task(asyncio.sleep(1))
task_created.set()
await task

def _run_in_loop():
aioutils.run_coro_with_timeout(_saved_sleep_task(), loop, 0.1)
aioutils.run_coro_with_timeout(_saved_sleep_task(), loop, 50)

with pytest.raises(EventLoopBlocked), patch.object(aioutils, "_LOADED_SYSTEM_TIMEOUT", 0.0):
await loop.run_in_executor(None, _run_in_loop)

# The outer .result() can raise EventLoopBlocked before the loop
# has scheduled the coroutine — wait until the inner task is
# created before asserting on it. Use an asyncio.Event so the
# wait yields back to the loop instead of blocking it.
await asyncio.wait_for(task_created.wait(), 1.0)
assert task is not None
# ensure the thread is shutdown
task.cancel()
Expand Down
Loading