Skip to content

feat: migrate to native types#1472

Merged
bdraco merged 5 commits into
python-zeroconf:masterfrom
Rotzbua:feat_migrate_native_types
Jan 16, 2025
Merged

feat: migrate to native types#1472
bdraco merged 5 commits into
python-zeroconf:masterfrom
Rotzbua:feat_migrate_native_types

Conversation

@Rotzbua

@Rotzbua Rotzbua commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

As defined in PEP 585 – Type Hinting Generics In Standard Collections

Restriction

Do not migrate folder src due issues with cython

Reference

@Rotzbua Rotzbua marked this pull request as draft January 12, 2025 14:33
@Rotzbua Rotzbua force-pushed the feat_migrate_native_types branch from 2de2f73 to 3d24643 Compare January 12, 2025 19:42
@codspeed-hq

codspeed-hq Bot commented Jan 12, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1472 will not alter performance

Comparing Rotzbua:feat_migrate_native_types (fb7b555) with master (d20d8c1)

Summary

✅ 4 untouched benchmarks

@Rotzbua Rotzbua marked this pull request as ready for review January 12, 2025 19:50
As defined in PEP 585 – Type Hinting Generics In Standard Collections
https://peps.python.org/pep-0585/

@bdraco bdraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rotzbua

@bdraco

bdraco commented Jan 16, 2025

Copy link
Copy Markdown
Member

@Rotzbua Would you please resolve conflicts when you get a chance

@bdraco

bdraco commented Jan 16, 2025

Copy link
Copy Markdown
Member

nevermind, it was a simple conflict

Comment thread tests/__init__.py Outdated
Comment thread tests/__init__.py Outdated
@bdraco bdraco merged commit 22a0fb4 into python-zeroconf:master Jan 16, 2025
@Rotzbua Rotzbua deleted the feat_migrate_native_types branch January 17, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants