Conversation
CodSpeed Performance ReportMerging #1465 will not alter performanceComparing Summary
|
Member
Author
|
Problem is |
Member
Author
|
set_created_ttl should probably be a private api to prevent mistakes because it will need to be rewarded to the cache after adjusting We also need tests to make sure created and ttl never end up in eq or hash |
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1465 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 30 30
Lines 3289 3311 +22
Branches 448 453 +5
=======================================
+ Hits 3282 3304 +22
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
bdraco
commented
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a
heapqto track cache expire to avoid enumerating the whole cache every 10sfixes #1464
technically breaking change: make
set_created_ttlprotected as they should never be called externally. It was not expected that they ever would have been though and the behavior was likely not correct if they were being called externally.technically breaking change:
reset_ttlhas been removed as we should not be mutating existing records as it can cause unexpected behaviors. They should be replaced in the cache instead as it has action at a distance side effects for downstream.