Skip to content

feat: small speed up to constructing outgoing packets #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 4 commits into from
Dec 19, 2023
Merged

feat: small speed up to constructing outgoing packets #1354

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
edb64f7
feat: small speed up to constructing outgoing packets
bdraco Dec 19, 2023
c81e6c2
Merge branch 'master' into outgoing_speed_up2
bdraco Dec 19, 2023
b31d011
fix: missed two
bdraco Dec 19, 2023
6c7d093
fix: do not type packets since its always called in pure python
bdraco Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/zeroconf/_protocol/outgoing.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,17 @@ cdef class DNSOutgoing:
cdef public cython.list authorities
cdef public cython.list additionals

cpdef _reset_for_next_packet(self)
cpdef void _reset_for_next_packet(self)

cdef _write_byte(self, cython.uint value)
cdef void _write_byte(self, cython.uint value)

cdef void _insert_short_at_start(self, unsigned int value)

cdef _replace_short(self, cython.uint index, cython.uint value)
cdef void _replace_short(self, cython.uint index, cython.uint value)

cdef _get_short(self, cython.uint value)

cdef _write_int(self, object value)
cdef void _write_int(self, object value)

cdef cython.bint _write_question(self, DNSQuestion question)

Expand All @@ -73,7 +73,7 @@ cdef class DNSOutgoing:
cdef cython.bint _write_record(self, DNSRecord record, double now)

@cython.locals(class_=cython.uint)
cdef _write_record_class(self, DNSEntry record)
cdef void _write_record_class(self, DNSEntry record)

@cython.locals(
start_size_int=object
Expand All @@ -91,7 +91,7 @@ cdef class DNSOutgoing:

cdef bint _has_more_to_add(self, unsigned int questions_offset, unsigned int answer_offset, unsigned int authority_offset, unsigned int additional_offset)

cdef _write_ttl(self, DNSRecord record, double now)
cdef void _write_ttl(self, DNSRecord record, double now)

@cython.locals(
labels=cython.list,
Expand All @@ -100,16 +100,16 @@ cdef class DNSOutgoing:
start_size=cython.uint,
name_length=cython.uint,
)
cpdef write_name(self, cython.str name)
cpdef void write_name(self, cython.str name)

cdef _write_link_to_name(self, unsigned int index)
cdef void _write_link_to_name(self, unsigned int index)

cpdef write_short(self, cython.uint value)
cpdef void write_short(self, cython.uint value)

cpdef write_string(self, cython.bytes value)
cpdef void write_string(self, cython.bytes value)

@cython.locals(utfstr=bytes)
cpdef _write_utf(self, cython.str value)
cdef void _write_utf(self, cython.str value)

@cython.locals(
debug_enable=bint,
Expand Down