fix: correct nsec record writing#1326
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1326 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 29 29
Lines 3104 3106 +2
Branches 521 522 +1
=======================================
+ Hits 3097 3099 +2
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
29c88ed to
e6e0d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueErrorto ensure we cannot write invalid recordsdns python can parse the message now
This may be the issue above, or the issues below may be bugs in the mdns stacks that are consuming the NSEC records not allowing the name compression
fixes #1320 *
fixes #1088 *