Skip to content

fix: correct nsec record writing#1326

Merged
bdraco merged 7 commits into
masterfrom
nsec_records_guards
Dec 10, 2023
Merged

fix: correct nsec record writing#1326
bdraco merged 7 commits into
masterfrom
nsec_records_guards

Conversation

@bdraco

@bdraco bdraco commented Dec 10, 2023

Copy link
Copy Markdown
Member

dns python can parse the message now

>>> import dns.message
>>> dns.message.from_wire(b'\x00\x00\x80\x00\x00\x00\x00\x01\x00\x00\x00\x00\x13eufy HomeBase2-2464\x04_hap\x04_tcp\x05local\x00\x00/\x80\x01\x00\x00\x11\x94\x00\t\xc0\x0c\x00\x05\x00\x00\x80\x00@')
[<dns.wire.Parser object at 0x1029e2060>, 7]
[(0, b'\x00\x00\x80\x00@')]
<DNS message, ID 0>

This may be the issue above, or the issues below may be bugs in the mdns stacks that are consuming the NSEC records not allowing the name compression

fixes #1320 *
fixes #1088 *

@codecov

codecov Bot commented Dec 10, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecea4e4) 99.77% compared to head (e6e0d7b) 99.77%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          29       29           
  Lines        3104     3106    +2     
  Branches      521      522    +1     
=======================================
+ Hits         3097     3099    +2     
  Misses          5        5           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title fix: ensure invalid nsec records cannot be written fix: correct nsec record writing Dec 10, 2023
@bdraco bdraco force-pushed the nsec_records_guards branch from 29c88ed to e6e0d7b Compare December 10, 2023 22:56
@bdraco bdraco marked this pull request as ready for review December 10, 2023 23:04
@bdraco bdraco merged commit cd7a16a into master Dec 10, 2023
@bdraco bdraco deleted the nsec_records_guards branch December 10, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android 14 fails to parse NSEC records for custom service type in version 0.128.0 Published service undiscoverable due to NSEC

1 participant