Skip to content

feat: speed up record updates#1301

Merged
bdraco merged 5 commits into
masterfrom
record_update
Nov 8, 2023
Merged

feat: speed up record updates#1301
bdraco merged 5 commits into
masterfrom
record_update

Conversation

@bdraco

@bdraco bdraco commented Nov 8, 2023

Copy link
Copy Markdown
Member
  • adds more cython types
  • convert RecordUpdate to a base class since NamedTuple has the unfortunate side effect of running a lambda on creation which can't be optimized away

@codecov

codecov Bot commented Nov 8, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_handlers/query_handler.py 100.00% <100.00%> (ø)
src/zeroconf/_record_update.py 100.00% <100.00%> (ø)
src/zeroconf/_services/browser.py 99.23% <100.00%> (+<0.01%) ⬆️
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)
src/zeroconf/_updates.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@bdraco bdraco marked this pull request as ready for review November 8, 2023 14:30
@bdraco bdraco merged commit d2af6a0 into master Nov 8, 2023
@bdraco bdraco deleted the record_update branch November 8, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant