Skip to content

feat: reduce overhead to answer questions#1250

Merged
bdraco merged 3 commits into
masterfrom
handlers_cleanup
Sep 2, 2023
Merged

feat: reduce overhead to answer questions#1250
bdraco merged 3 commits into
masterfrom
handlers_cleanup

Conversation

@bdraco

@bdraco bdraco commented Sep 2, 2023

Copy link
Copy Markdown
Member
  • only build known_answers_set once per question set
  • remove unused variables and code paths
  • unpack functions only called in one place

- only build known_answers_set once per question set
- remove unused variables and code paths
@codecov

codecov Bot commented Sep 2, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/zeroconf/__init__.py 100.00%
src/zeroconf/_handlers/query_handler.py 100.00%

📢 Thoughts on this report? Let us know!.

- only build known_answers_set once per question set
- remove unused variables and code paths
@bdraco bdraco marked this pull request as ready for review September 2, 2023 22:19
@bdraco bdraco merged commit 7cb8da0 into master Sep 2, 2023
@bdraco bdraco deleted the handlers_cleanup branch September 2, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant