Skip to content

feat: use server_key when processing DNSService records #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 2 commits into from
Aug 28, 2023
Merged

feat: use server_key when processing DNSService records #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6365c3
feat: use server_key when processing DNSService records
bdraco Aug 28, 2023
7879823
feat: use server_key when processing DNSService records
bdraco Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/zeroconf/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,8 @@ async def async_unregister_service(self, info: ServiceInfo) -> Awaitable:
# If another server uses the same addresses, we do not want to send
# goodbye packets for the address records

assert info.server is not None
entries = self.registry.async_get_infos_server(info.server.lower())
assert info.server_key is not None
entries = self.registry.async_get_infos_server(info.server_key)
broadcast_addresses = not bool(entries)
return asyncio.ensure_future(
self._async_broadcast_service(info, _UNREGISTER_TIME, 0, broadcast_addresses)
Expand Down
4 changes: 2 additions & 2 deletions src/zeroconf/_services/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ def _process_record_threadsafe(self, zc: 'Zeroconf', record: DNSRecord, now: flo
old_server_key = self.server_key
self.name = record.name
self.server = record.server
self.server_key = record.server.lower()
self.server_key = record.server_key
self.port = record.port
self.weight = record.weight
self.priority = record.priority
Expand Down Expand Up @@ -586,7 +586,7 @@ def set_server_if_missing(self) -> None:
"""
if self.server is None:
self.server = self._name
self.server_key = self.server.lower()
self.server_key = self.key

def load_from_cache(self, zc: 'Zeroconf', now: Optional[float] = None) -> bool:
"""Populate the service info from the cache.
Expand Down