feat: simplify code to unpack properties#1237
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
==========================================
- Coverage 99.82% 99.78% -0.04%
==========================================
Files 25 25
Lines 2809 2805 -4
Branches 480 479 -1
==========================================
- Hits 2804 2799 -5
Misses 3 3
- Partials 2 3 +1
☔ View full report in Codecov by Sentry. |
bdraco
commented
Aug 27, 2023
Comment on lines
-364
to
-368
| for s in strs: | ||
| key, _, value = s.partition(b'=') | ||
| # Only update non-existent properties | ||
| if key and key not in result: | ||
| result[key] = value or None |
Member
Author
There was a problem hiding this comment.
This was O(n)*2 + the cost of the python loop
Member
Author
|
retest is good |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of most common operations from discovery so anything we can do to improve the performance here is a win.
We may need to cython