Skip to content

feat: optimize unpacking properties in ServiceInfo #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Aug 15, 2023
Merged

feat: optimize unpacking properties in ServiceInfo #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/zeroconf/_services/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,20 +361,11 @@ def _unpack_text_into_properties(self) -> None:
strs.append(text[index : index + length])
index += length

key: bytes
value: Optional[bytes]
for s in strs:
key_value = s.split(b'=', 1)
if len(key_value) == 2:
key, value = key_value
else:
# No equals sign at all
key = s
value = None

key, _, value = s.partition(b'=')
# Only update non-existent properties
if key and key not in result:
result[key] = value
result[key] = value or None

# Properties should be set atomically
# in case another thread is reading them
Expand Down