👍 Thanks for this, hope it can be merged soon. For working with existing protocols that use strictly-invalid service types, we have had to adjust our monkeypatch several times. 🐒😄

@bdraco thanks for considering this PR when you have time

This looks fine. It needs explicit test coverage for a few more places before merging.

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0094e26) 99.78% compared to head (c8996e6) 99.78%.
Report is 1 commits behind head on master.

@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          22       22           
  Lines        2757     2757           
  Branches      480      480           
=======================================
  Hits         2751     2751           
  Misses          3        3           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The following can be called directly so they should get a simple test to make sure disabling works when called directly:

• bound async_check_service

These are exposed at the top level for backwards compat which we likely need to maintain forever so they should get a test as well:

• service_type_name
• instance_name_from_service_info
  

  python-zeroconf/src/zeroconf/__init__.py

  Line 69 in 8a9dc0b

  from ._utils.name import service_type_name # noqa # import needed for backwards compat

  
  

  python-zeroconf/src/zeroconf/__init__.py

  Line 62 in 8a9dc0b

  instance_name_from_service_info,

The following can be called directly so they should get a simple test to make sure disabling works when called directly:

• bound async_check_service

These are exposed at the top level for backwards compat which we likely need to maintain forever so they should get a test as well:

• service_type_name

• instance_name_from_service_info
  

  python-zeroconf/src/zeroconf/__init__.py

  Line 69 in 8a9dc0b

  from ._utils.name import service_type_name # noqa # import needed for backwards compat

  python-zeroconf/src/zeroconf/__init__.py

  Line 62 in 8a9dc0b

  instance_name_from_service_info,

Hi @bdraco, please take a look now 👍

I was not sure where to put those calls:

• Added explicit call to Zeroconf.async_check_service in test_asyncio.py
• Added a new unit test in utils/test_name.py to check explicit calls to service_type_name and instance_name_from_service_info

Also, I re-pushed the branch to rename the old 2 commits (just de-capitalized the titles, after seeing a CI fail with the GAs 😅)

Tested on production. Didn't find any issues

Thanks @azogue