Skip to content

fix: add missing if TYPE_CHECKING guard to generate_service_query#1198

Merged
bdraco merged 1 commit into
masterfrom
cast2
Jul 23, 2023
Merged

fix: add missing if TYPE_CHECKING guard to generate_service_query#1198
bdraco merged 1 commit into
masterfrom
cast2

Conversation

@bdraco

@bdraco bdraco commented Jul 23, 2023

Copy link
Copy Markdown
Member

This is a small cleanup but the primary goal here it to do a rebuild with cython 3

@codecov

codecov Bot commented Jul 23, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a56c776) 99.78% compared to head (71ddd13) 99.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1198   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          22       22           
  Lines        2728     2729    +1     
  Branches      474      473    -1     
=======================================
+ Hits         2722     2723    +1     
  Misses          3        3           
  Partials        3        3           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_services/browser.py 99.14% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review July 23, 2023 22:09
@bdraco bdraco merged commit ac53adf into master Jul 23, 2023
@bdraco bdraco deleted the cast2 branch July 23, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant