fix: always answer QU questions when the exact same packet is received from different sources in sequence#1178
Merged
Merged
Conversation
Member
Author
|
confirmed this fixes the issue. Lots of tests to update. verified no performance regression |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1178 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 22 22
Lines 2676 2687 +11
Branches 466 471 +5
=======================================
+ Hits 2671 2682 +11
Misses 3 3
Partials 2 2
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the exact same packet with a QU question is asked from two different sources in a 1s window we end up ignoring the second one as a duplicate. We should still respond in this case because the client wants a unicast response and the question may not be answered by the previous packet since the response may not be multicast.
fix: include NSEC records in initial broadcast when registering a new service
This also revealed that we do not send NSEC records in the initial broadcast. This needed to be fixed in this PR as well for everything to work as expected since all the tests would fail with 2 updates otherwise.